Cpunet rebase 0.33.0 beta

.cargo/mutants.toml

@@ -1,5 +1,5 @@
 additional_cargo_args = ["--all-features"]
-examine_globs = ["units/src/**/*.rs", "primitives/src/**/*.rs"]
+examine_globs = ["consensus_encoding/src/**/*.rs", "units/src/**/*.rs", "primitives/src/**/*.rs"]
 exclude_globs = [
     "units/src/amount/verification.rs" # kani tests
 ]
@@ -9,30 +9,59 @@ exclude_re = [
     "impl fmt::Debug",
     ".*Error",
     "deserialize", # Skip serde mutation tests
+    "serde_details::<impl de::Visitor<'_>", # Skip serde mutation tests
     "Iterator", # Mutating operations in an iterator can result in an infinite loop
-    "match arm", "match guard", # New addition in cargo-mutants 25.0.1 deletes match arms and replaces match guards even in excluded functions
+    "<impl .*Decodable for .*>::decoder", # Mutant replacing Default::default() is equivalent to returning new()
+    "<impl .*Decoder for .*>::read_limit", # Function is for optimization and does not need to be tested.
+
 
     # ----------------------------------Crate-specific exclusions----------------------------------
-    # Units
+    # units
     # src/amount/mod.rs
-    "parse_signed_to_satoshi", # Can't kill all mutants since there is no denomination smaller than Satoshi
-    "fmt_satoshi_in", # Related to formatting/display
-    "dec_width", # Replacing num /= 10 with num %=10 in a loop causes a timeout due to infinite loop
+    "units/.* parse_signed_to_satoshi", # Can't kill all mutants since there is no denomination smaller than Satoshi
+    "units/.* fmt_satoshi_in", # Related to formatting/display
+    "units/.* dec_width", # Replacing num /= 10 with num %=10 in a loop causes a timeout due to infinite loop
     # src/locktime/relative.rs
-    "Time::to_consensus_u32", # Mutant from replacing | with ^, this returns the same value since the XOR is taken against the u16 with an all-zero bitmask
-    "FeeRate::fee_vb", # Deprecated
-    "FeeRate::fee_wu", # Deprecated
-    "SignedAmount::checked_abs", # Deprecated
-    "NumberOfBlocks::value", # Deprecated
-    "NumberOf512Seconds::to_consensus_u32", # Deprecated
+    "units/.* LockTime::to_consensus_u32", # Mutant from replacing | with ^, this returns the same value since the XOR is taken against the u16 with an all-zero bitmask
+    "units/.* CompactTarget::to_hex", # Deprecated
+    "units/.* FeeRate::fee_vb", # Deprecated
+    "units/.* FeeRate::fee_wu", # Deprecated
+    "units/.* SignedAmount::checked_abs", # Deprecated
+    "units/.* NumberOfBlocks::to_consensus_u32", # Deprecated
+    "units/.* NumberOfBlocks::value", # Deprecated
+    "units/.* NumberOf512Seconds::to_consensus_u32", # Deprecated
+    "units/.* NumberOf512Seconds::value", # Deprecated
+    "units/.* MedianTimePast::to_consensus_u32", # Deprecated
+    "units/.* Height::to_consensus_u32", # Deprecated
+    "units/.* Sequence::to_hex", # Deprecated
+    "units/.* Sequence::from_512_second_intervals", # Mutant from replacing | with ^, this returns the same value since the XOR is taken against the u16 with an all-zero bitmask
 
     # primitives
-    "Sequence::from_512_second_intervals", # Mutant from replacing | with ^, this returns the same value since the XOR is taken against the u16 with an all-zero bitmask
-    "Opcode::classify", # Not possible to kill all mutants without individually checking every opcode classification
-    "Block<Checked>::cached_witness_root", # Skip getters
-    "Block<Checked>::transactions", # Skip getters
-    "Script::to_bytes", # Deprecated
-    "decode_cursor", # Mutating operations in decode_cursor can result in an infinite loop
-    "fmt_debug", # Mutants from formatting/display changes
-    "fmt_debug_pretty", # Mutants from formatting/display changes
+    "primitives/.* Opcode::classify", # Not possible to kill all mutants without individually checking every opcode classification
+    "primitives/.* Block<Checked>::cached_witness_root", # Skip getters
+    "primitives/.* Block<Checked>::transactions", # Skip getters
+    "primitives/.* Script::to_bytes", # Deprecated
+    "primitives/.* decode_cursor", # Mutating operations in decode_cursor can result in an infinite loop
+    "primitives/.* fmt_debug", # Mutants from formatting/display changes
+    "primitives/.* fmt_debug_pretty", # Mutants from formatting/display changes
+    "primitives/.* Script::to_hex", # Deprecated
+    "primitives/.* Script<T>::to_hex", # Deprecated
+    "primitives/.* ScriptBuf::to_hex", # Deprecated
+    "primitives/.* ScriptBuf<T>::to_hex", # Deprecated
+    "primitives/.* <impl Encoder for .*Encoder<'_>>::current_chunk", # Replacing the return with Some(vec![]) causes an infinite loop.
+    "primitives/.* <impl Encoder for .*Encoder<'_>>::advance", # Replacing the return with true causes an infinite loop.
+    "primitives/.* <impl Decoder for WitnessDecoder>::push_bytes", # Replacing == with != causes an infinite loop
+    "primitives/.* WitnessDecoder::resize_if_needed", # Replacing *= with += still resizes the buffer making the mutant untestable.
+    "primitives/.* WitnessDecoder::reserve_batch", # Mutations cause an infinite loop
+    "primitives/.* replace \\+ with \\* in MerkleNode::calculate_root", # Replacing + with * causes an infinite loop
+    "primitives/.* replace == with != in MerkleNode::calculate_root", # Replacing == with != isn't caught unless alloc is disabled.
+
+    # consensus_encoding - most of these are for mutations in the logic used to determine when to stop encoding or decoding.
+    "consensus_encoding/.* <impl Decoder for ArrayDecoder<N>>::push_bytes", # Mutations cause an infinite loop
+    "consensus_encoding/.* <impl Decoder for .*>::end", # Mutations cause an infinite loop
+    "consensus_encoding/.* encode_to_vec", # Mutations cause an infinite loop
+    "consensus_encoding/.* encode_to_writer", # Mutations cause an infinite loop
+    "consensus_encoding/.* decode_from_slice", # Mutations cause an infinite loop
+    "consensus_encoding/.* decode_from_read", # Mutations cause an infinite loop
+    "consensus_encoding/.* <impl Decoder for .*>::push_bytes", # Mutations cause an infinite loop
 ]

.github/actions/prepare/action.yml

@@ -0,0 +1,36 @@
+name: 'Prepare Rust Environment'
+description: 'Setup Rust toolchain and install RBMT'
+inputs:
+  toolchain:
+    description: 'Rust toolchain to use (nightly reads from nightly-version file)'
+    required: false
+    default: 'stable'
+  components:
+    description: 'Rust components to install (e.g., clippy, rustfmt)'
+    required: false
+    default: ''
+runs:
+  using: "composite"
+  steps:
+    - name: "Determine toolchain"
+      id: toolchain
+      shell: bash
+      run: |
+        if [ "${INPUTS_TOOLCHAIN}" = "nightly" ]; then
+          TOOLCHAIN="$(cat nightly-version)"
+        else
+          TOOLCHAIN="${INPUTS_TOOLCHAIN}"
+        fi
+        echo "version=$TOOLCHAIN" >> $GITHUB_OUTPUT
+      env:
+        INPUTS_TOOLCHAIN: ${{ inputs.toolchain }}
+
+    - name: "Setup requested toolchain"
+      uses: actions-rust-lang/setup-rust-toolchain@1780873c7b576612439a134613cc4cc74ce5538c # v1.15.2
+      with:
+        toolchain: stable,${{ steps.toolchain.outputs.version }}
+        components: ${{ inputs.components }}
+
+    - name: "Install RBMT"
+      shell: bash
+      run: cargo +stable install --git https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools.git --rev "$(cat rbmt-version)" cargo-rbmt --locked

.github/dependabot.yml

@@ -6,3 +6,7 @@ updates:
     schedule:
       # Check for updates to GitHub Actions every week
       interval: "weekly"
+    # Defines a cooldown period for dependency updates,
+    # allowing updates to be delayed for a configurable number of days.
+    cooldown:
+      default-days: 60

.github/workflows/README.md

@@ -28,7 +28,13 @@ Run from rust.yml unless stated otherwise. Unfortunately we are now exceeding th
 14. `ASAN`
 15. `WASM`
 16. `Kani`
-17. `Coveralls` - run by `coveralls.yml`
-18. `release` - run by `release.yml`
-19. `labeler` - run by `manage-pr.yml`
-20. `Shellcheck` - run by `shellcheck.yml`
+17. `API`
+18. `Policy` - enforce repository coding policy.
+19. `Re-exports`
+20. `DiffMutants`
+21. `release` - run by `release.yml`
+22. `labeler` - run by `manage-pr.yml`
+23. `Shellcheck` - run by `shellcheck.yml`
+
+If any change touches the `.github/` directory then the `zizmor`, run by `zizmor.yml`, will be
+triggered for that PR.

.github/workflows/cargo-semver-checks-version

@@ -1 +1 @@
-0.41.0
+0.46.0

.github/workflows/cron-daily-fuzz.yml

@@ -7,51 +7,69 @@ on:
     # - 6am CET
     # - 4pm AEDT
     - cron: '00 05 * * *'
+permissions: {}
 
 jobs:
   fuzz:
     if: ${{ !github.event.act }}
     runs-on: ubuntu-24.04
+    permissions:
+      contents: read
     strategy:
       fail-fast: false
       matrix:
         # We only get 20 jobs at a time, we probably don't want to go
         # over that limit with fuzzing because of the hour run time.
         fuzz_target: [
-          bitcoin_deserialize_address,
+          bitcoin_arbitrary_block,
+          bitcoin_arbitrary_script,
+          bitcoin_arbitrary_transaction,
+          bitcoin_arbitrary_witness,
           bitcoin_deserialize_block,
           bitcoin_deserialize_prefilled_transaction,
           bitcoin_deserialize_psbt,
           bitcoin_deserialize_script,
           bitcoin_deserialize_transaction,
           bitcoin_deserialize_witness,
-          bitcoin_deser_net_msg,
-          bitcoin_outpoint_string,
-          bitcoin_p2p_address_roundtrip,
+          bitcoin_parse_address,
+          bitcoin_parse_outpoint,
           bitcoin_script_bytes_to_asm_fmt,
+          consensus_encoding_decode_array,
+          consensus_encoding_decode_byte_vec,
+          consensus_encoding_decode_compact_size,
+          consensus_encoding_decode_decoder2,
           hashes_json,
           hashes_ripemd160,
           hashes_sha1,
           hashes_sha256,
-          hashes_sha512_256,
           hashes_sha512,
-          units_deserialize_amount,
+          hashes_sha512_256,
+          p2p_arbitrary_addrv2,
+          p2p_deserialize_addrv2,
+          p2p_deserialize_raw_net_msg,
+          units_arbitrary_weight,
+          units_parse_amount,
+          units_parse_int,
+          units_standard_checks,
         ]
     steps:
       - name: Install test dependencies
         run: sudo apt-get update -y && sudo apt-get install -y binutils-dev libunwind8-dev libcurl4-openssl-dev libelf-dev libdw-dev cmake gcc libiberty-dev
-      - uses: actions/checkout@v4
-      - uses: actions/cache@v4
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          persist-credentials: false
+      - uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
+
         id: cache-fuzz
         with:
           path: |
             ~/.cargo/bin
             fuzz/target
             target
           key: cache-${{ matrix.target }}-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
-      - uses: dtolnay/rust-toolchain@stable
+      - uses: dtolnay/rust-toolchain@5d458579430fc14a04a08a1e7d3694f545e91ce6 # stable
         with:
-          toolchain: '1.65.0'
+          toolchain: '1.74.0'
       - name: fuzz
         run: |
           if [[ "${{ matrix.fuzz_target }}" =~ ^bitcoin ]]; then
@@ -60,7 +78,7 @@ jobs:
           echo "Using RUSTFLAGS $RUSTFLAGS"
           cd fuzz && ./fuzz.sh "${{ matrix.fuzz_target }}"
       - run: echo "${{ matrix.fuzz_target }}" >executed_${{ matrix.fuzz_target }}
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
           name: executed_${{ matrix.fuzz_target }}
           path: executed_${{ matrix.fuzz_target }}
@@ -69,9 +87,13 @@ jobs:
     if: ${{ !github.event.act }}
     needs: fuzz
     runs-on: ubuntu-24.04
+    permissions:
+      contents: read
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v4
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          persist-credentials: false
+      - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
       - name: Display structure of downloaded files
         run: ls -R
       - run: find executed_* -type f -exec cat {} + | sort > executed

.github/workflows/cron-daily-kani.yml

@@ -3,12 +3,17 @@ name: Kani CI
 on:
   schedule:
     - cron: '59 23 * * *'       # midnight every day.
+permissions: {}
 jobs:
   run-kani:
     runs-on: ubuntu-24.04
+    permissions:
+      contents: read
     steps:
       - name: 'Checkout your code.'
-        uses: actions/checkout@v4
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          persist-credentials: false
 
       - name: 'Run Kani on your code.'
-        uses: model-checking/kani-github-action@v1.1
+        uses: model-checking/kani-github-action@f838096619a707b0f6b2118cf435eaccfa33e51f # v1.1

.github/workflows/cron-weekly-cargo-mutants.yml

@@ -3,16 +3,22 @@ on:
   schedule:
     - cron: "0 0 * * 0" # runs weekly on Sunday at 00:00
   workflow_dispatch: # allows manual triggering
+permissions: {}
 jobs:
   cargo-mutants:
     runs-on: ubuntu-24.04
+    permissions:
+      contents: read
+      issues: write
     steps:
-      - uses: actions/checkout@v4
-      - uses: taiki-e/install-action@v2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          persist-credentials: false
+      - uses: taiki-e/install-action@81ee1d48d9194cdcab880cbdc7d36e87d39874cb # v2.62.45
         with:
           tool: cargo-mutants
       - run: cargo mutants --in-place --no-shuffle
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         if: always()
         with:
           name: mutants.out
@@ -22,13 +28,15 @@ jobs:
         run: |
           if [ -s mutants.out/missed.txt ]; then
             echo "New missed mutants found"
+            MUTANTS_VERSION=$(cargo mutants --version)
             gh issue create \
             --title "New Mutants Found" \
             --body "$(cat <<EOF
           Displaying up to the first 10 mutants:
-
+          \`\`\`
           $(head -n 10 mutants.out/missed.txt)
-
+          \`\`\`
+          Running cargo mutants version: ${MUTANTS_VERSION}
           For the complete list, please check the [mutants.out artifact](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}).
           EOF
           )"

.github/workflows/cron-weekly-rustfmt.yml

@@ -3,26 +3,33 @@ on:
   schedule:
     - cron: "0 0 * * 0" # runs weekly on Sunday at 00:00
   workflow_dispatch: # allows manual triggering
+permissions: {}
 jobs:
   format:
     name: Nightly rustfmt
     runs-on: ubuntu-24.04
+    permissions:
+      contents: write
+      pull-requests: write
     steps:
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@nightly
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          persist-credentials: false
+      - uses: dtolnay/rust-toolchain@55d80eb3c5a4228eec5390a083c092095115c6f1 # nightly
         with:
           components: rustfmt
       - name: Run Nightly rustfmt
         # Run the formatter and manually remove trailing whitespace.
-        run: cargo +nightly fmt && find . -type f -name '*.rs' -exec sed -i 's/ $//' {} \;
+        run: cargo +nightly fmt && git ls-files -- '*.rs' -z | xargs sed -E -i'' -e 's/[[:space:]]+$//'
       - name: Get the current date
         run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v7
+        uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8
         with:
           author: Fmt Bot <bot@example.com>
           title: Automated nightly rustfmt (${{ env.date }})
           body: |
            Automated nightly `rustfmt` changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
           commit-message: ${{ env.date }} automated rustfmt nightly 
           labels: rustfmt
+