WIP experimental feature for auto detection device/simulator selected in xcode#447
WIP experimental feature for auto detection device/simulator selected in xcode#447ark-konopacki wants to merge 2 commits intocalabash:developfrom
Conversation
ark-konopacki
changed the title
lib/run_loop/detect_aut/xcode.rb
Outdated
| # @!visibility private | ||
| def ignore_xcodeproj?(path) | ||
| def self.find_user_state_files | ||
| username = Etc.getpwuid.name |
There was a problem hiding this comment.
Add a new method to RunLoop::Environment: self.username.
|
This needs rspec tests. |
lib/run_loop/detect_aut/xcode.rb
Outdated
| username = Etc.getpwuid.name | ||
| user_state_file_paths = [] | ||
| Dir.glob("#{Dir.pwd}/**/xcuserdata/#{username}.xcuserdatad/UserInterfaceState.xcuserstate").each do |path| | ||
| next if ignore_xcodeproj?(path) |
There was a problem hiding this comment.
ignore_xcodeproj is an instance method. You cannot call it from a class method.
|
@ark-konopacki You should rebase this. If you need help; we can pair. Once you have rebased, we can discuss why the test are failing. |
|
@jmoody sorry for mess in PR, now tests are passing and selected device (only sim) is detected, so basically ready for review. |
|
@ark-konopacki We need to rebase this. Let's since next week; I will be back in Germany by Monday. Thanks! |
lib/run_loop/detect_aut/xcode.rb
Outdated
| @@ -1,3 +1,5 @@ | |||
| require 'etc' | |||
There was a problem hiding this comment.
Move this to inside the module definition.
module RunLoop
module DetectAUT
require "etc"
end
end
Prefer " vs. '.
|
This is looking much better! You gotta rebase it though. :) |
|
@jmoody Ok it is better now, but i cannot use |
|
Can one of the admins verify this patch? |
ark-konopacki
force-pushed
the
feature/auto-detect-selected-device
branch
from
bf8bd08 to
958e43a
Compare
|
@jmoody can you please check why jenkins failing ? |
|
This should be rebased against develop. I think we might be able to simplify this by reading the Maybe this could be implemented in CoreSimulator? See #647 I would ask in the community to see if there is support for this feature. |
Rebase against develop
3 participants
WIP do not merge!
experimental feature for auto detection device/simulator selected in xcode described in calabash/calabash-ios#651
can be checked in calabash-ios console (should wait some time about 5 sec after changing device and running server)