feat: Remove imap::Session::sync_seen_flags()#7758
Open
Conversation
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
from
266cc9f to
397de34
Compare
This way they also can be processed by `markseen_msgs()` resulting in MDNs which improves multi-device synchronization and updates contacts' `last_seen`. I.e. leave it up to the UIs.
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
from
397de34 to
3955b41
Compare
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
from
3955b41 to
91ea007
Compare
iequidoo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #7742
Maybe we should merge this first and then #7928 will be easier to debug, maybe it will reproduce more stably or, vice versa, disappear at all.
However, there's a problem (maybe): with this change, messages will start to arrive always unseen and then be marked as seen as soon as MDNs are received, this will probably cause notifications to appear and then disappear quickly if messages have been already seen on another device.