-
Notifications
You must be signed in to change notification settings - Fork 4
new API structure #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
new API structure #159
Conversation
sujaya-sys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guolau I don't really have context on this change so mainly looked for wording inconsistencies. Hope that helps - feel free to disregard anything that doesn't make sense :)
api-reference/client-certificates/creates-a-new-client-certificate.mdx
Outdated
Show resolved
Hide resolved
| @@ -1,3 +1,4 @@ | |||
| --- | |||
| openapi: get /v1/analytics/api-checks/{id} | |||
| title: Get API Check analytics | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: Get API Check analytics | |
| title: Get API check analytics |
api-reference/client-certificates/deletes-a-client-certificate.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| #### Broken Navigation Links (in docs.json but no MDX file) | ||
|
|
||
| | Missing File | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing context on the purpose of this doc, but why are we documenting issues, missing files, open questions, inconsistencies etc here?
guolau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, Dan. IMO will look much better than our current API reference once we've polished it up.
| { | ||
| "group": "Triggers", | ||
| "pages": [ | ||
| "api-reference/triggers/get-the-check-group-trigger", | ||
| "api-reference/triggers/create-the-check-group-trigger", | ||
| "api-reference/triggers/delete-the-check-group-trigger", | ||
| "api-reference/triggers/get-the-check-trigger", | ||
| "api-reference/triggers/create-the-check-trigger", | ||
| "api-reference/triggers/delete-the-check-trigger" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go in the Detect section, since it's about triggering check runs
| "api-reference/checks/update-a-check" | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't separate these endpoints into Uptime and Synthetic since some of these endpoints apply to both (like list all checks).
I think something like this would be bette:
- api-reference/checks/list-all-checks
- api-reference/checks/retrieve-a-check
- api-reference/checks/delete-a-check
- API check
- api-reference/checks/create-an-api-check
- api-reference/checks/update-an-api-check
- Browser check
- api-reference/checks/create-a-browser-check
- api-reference/checks/update-a-browser-check
- Multistep check
- api-reference/checks/create-a-multi-step-check
- api-reference/checks/update-a-multi-step-check
- DNS monitor
- api-reference/monitors/create-a-dns-monitor
- api-reference/monitors/update-a-dns-monitor
- Heartbeat monitor
- api-reference/heartbeats/create-a-heartbeat-check
- api-reference/heartbeats/update-a-heartbeat-check
- api-reference/heartbeats/get-heartbeat-availability
- api-reference/heartbeats/get-a-list-of-events-for-a-heartbeat
- api-reference/heartbeats/get-a-specific-heartbeat-event
- TCP monitor
- api-reference/checks/create-a-tcp-check
- api-reference/checks/update-an-tcp-check
- URL monitor
- api-reference/monitors/create-a-url-monitor
- api-reference/monitors/update-an-url-monitor
- api-reference/checks/create-a-check
- api-reference/checks/update-a-check
| "group": "Locations", | ||
| "pages": [ | ||
| "api-reference/location/lists-all-supported-locations", | ||
| "api-reference/private-locations/list-all-private-locations", | ||
| "api-reference/private-locations/create-a-private-location", | ||
| "api-reference/private-locations/retrieve-a-private-location", | ||
| "api-reference/private-locations/update-a-private-location", | ||
| "api-reference/private-locations/remove-a-private-location", | ||
| "api-reference/private-locations/generate-a-new-api-key-for-a-private-location", | ||
| "api-reference/private-locations/remove-an-existing-api-key-for-a-private-location", | ||
| "api-reference/private-locations/get-private-location-health-metrics-from-a-window-of-time" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should go under Platform? Additionally, I'd separate api-reference/location/lists-all-supported-locations (just lists public locations) from the private location endpoints
| "group": "Check Groups", | ||
| "pages": [ | ||
| "api-reference/check-groups/list-all-check-groups", | ||
| "api-reference/check-groups/create-a-check-group", | ||
| "api-reference/check-groups/retrieve-one-check-in-a-specific-group-with-group-settings-applied", | ||
| "api-reference/check-groups/retrieve-a-check-group", | ||
| "api-reference/check-groups/update-a-check-group", | ||
| "api-reference/check-groups/delete-a-check-group", | ||
| "api-reference/check-groups/retrieve-all-checks-in-a-specific-group-with-group-settings-applied", | ||
| "api-reference/check-groups/create-a-check-group-v2", | ||
| "api-reference/check-groups/update-a-check-group-v2" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should change the order so that the V2 endpoints are higher up:
| "group": "Check Groups", | |
| "pages": [ | |
| "api-reference/check-groups/list-all-check-groups", | |
| "api-reference/check-groups/create-a-check-group", | |
| "api-reference/check-groups/retrieve-one-check-in-a-specific-group-with-group-settings-applied", | |
| "api-reference/check-groups/retrieve-a-check-group", | |
| "api-reference/check-groups/update-a-check-group", | |
| "api-reference/check-groups/delete-a-check-group", | |
| "api-reference/check-groups/retrieve-all-checks-in-a-specific-group-with-group-settings-applied", | |
| "api-reference/check-groups/create-a-check-group-v2", | |
| "api-reference/check-groups/update-a-check-group-v2" | |
| ] | |
| }, | |
| "group": "Check Groups", | |
| "pages": [ | |
| "api-reference/check-groups/list-all-check-groups", | |
| "api-reference/check-groups/retrieve-a-check-group", | |
| "api-reference/check-groups/retrieve-one-check-in-a-specific-group-with-group-settings-applied", | |
| "api-reference/check-groups/create-a-check-group-v2", | |
| "api-reference/check-groups/update-a-check-group-v2", | |
| "api-reference/check-groups/delete-a-check-group", | |
| "api-reference/check-groups/retrieve-all-checks-in-a-specific-group-with-group-settings-applied", | |
| "api-reference/check-groups/create-a-check-group", | |
| "api-reference/check-groups/update-a-check-group" | |
| ] | |
| }, |
| "api-reference/status-pages/get-all-subscriptions-for-a-specific-status-page", | ||
| "api-reference/status-pages/delete-a-subscription-belonging-to-a-specific-status-page" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put these in their own "Status Page Subscriptions" category
| @@ -0,0 +1,279 @@ | |||
| # API Reference Documentation Architecture | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good call to document how the API reference comes together. We can probably clean this up and make it more concise, but this is good for now.
| @@ -1,3 +1,4 @@ | |||
| --- | |||
| openapi: get /v1/analytics/api-checks/{id} | |||
| title: Get API Check analytics | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api-reference/client-certificates/shows-one-client-certificate.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this endpoint exist publicly? I'm not seeing it in our OpenAPI spec https://api.checklyhq.com/openapi.json
Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>
Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>
Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>
…cate.mdx Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>
…s.mdx Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>
Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>
Co-authored-by: Susa Tünker <74345218+sujaya-sys@users.noreply.github.com>

Affected Components
Notes for the Reviewer
New Dependency Submission
Screenshots