Feature/support passing ref to user data#724
Open
jaekunchoi wants to merge 14 commits intocloudtools:mainfrom
Open
Feature/support passing ref to user data#724jaekunchoi wants to merge 14 commits intocloudtools:mainfrom
jaekunchoi wants to merge 14 commits intocloudtools:mainfrom
Conversation
added 9 commits
May 22, 2017 23:52
Member
|
Nice change. I have two questions:
|
added 2 commits
June 25, 2017 23:42
…the test. Added condition to include ref search
Author
|
@markpeek thanks for the feedback. I've updated userdata script with multiple refs and asserting these results in the test. It passes with mutliple Refs being replaced. Thanks again! |
Author
|
@markpeek do you have any feedback on the changes? |
|
Plans to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref is now supported in the method from_file of helper file.
Also added unit test
Should address issue #724
@markpeek please review. I was able to successfully run userdata with Ref on AWS.