Conversation
|
Thanks for your contribution 👍 Pull request itself looks good. The test matrix is currently not running through because of an outdated CI workflow, so we need to make a few adjustments before we can merge this. The changes will be similar to the work done in reactphp/socket#299, reactphp/socket#300 and reactphp/socket#310. Is this something you can look into? |
|
Thanks to @SimonFrings, I was able to rebase my branch after implementing the new feature described in #33. Fortunately, there were no conflicts, and all tests passed successfully. This PR is now ready to be reviewed by @clue and @SimonFrings. 🎉 |
Really thankful for our workshop. I feel confident that I will be able to work on this independently in the future. 🥳 |
SimonFrings
left a comment
There was a problem hiding this comment.
@yadaiio Thanks for rebasing, these changes look good to me 👍
This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.
Builds on top of #10 and clue/reactphp-redis#146.