Skip to content

Wrong Cron Flow Settings #255

Merged
raphael-goetz merged 2 commits intomainfrom
253-wrong-cron-flow-definition
Mar 2, 2026
Merged

Wrong Cron Flow Settings #255
raphael-goetz merged 2 commits intomainfrom
253-wrong-cron-flow-definition

Conversation

@raphael-goetz
Copy link
Member

Resolves: #253

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CRON flow type definition to model cron scheduling as five individual flow settings (minute/hour/day-of-month/month/day-of-week) instead of a single CRON_CODE object, aligning the definition with how the cron adapter expects settings (per #253).

Changes:

  • Replaced the CRON_CODE flow setting with five separate CRON field settings in the CRON flow type definition.
  • Removed the CRON_CODE object data type definition.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
definitions/cron/flow_type/cron.proto.json Defines five individual cron field settings (minute, hour, day-of-month, month, day-of-week) for the CRON flow type.
definitions/cron/data_type/object/cron_code.proto.json Removes the no-longer-used CRON_CODE object data type definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check the datatypes, otherwise it looks fine

@raphael-goetz raphael-goetz merged commit 67300f0 into main Mar 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cron Flow Definition is wrong

3 participants