🤖 feat: secrets management in Settings → Projects by ammar-agent · Pull Request #2139 · coder/mux

ammar-agent · 2026-02-03T21:49:57Z

Summary

Moves secrets management from a standalone modal into the Settings → Projects section, keeping all project-level configuration in one place. The sidebar project icons have been updated to use a Settings gear icon that opens the full project settings page.

Background

The original implementation added a separate SecretsModal opened via a key icon on each project header. This worked but meant project secrets were separate from other project settings (like MCP servers). Consolidating into Settings → Projects provides a more consistent UX.

Implementation

New ProjectSecretsSection component: Inline secrets editor with Add/Import/Save/Discard functionality
Integrated into ProjectSettingsSection: Added as a new section between the project selector and MCP Servers
Updated ProjectSidebar: Settings icon (was key icon) now opens Settings → Projects via openProjectSettings()
Removed SecretsModal: No longer needed

Key behaviors preserved:

Import from other projects (doesn't overwrite existing keys)
Auto-capitalize keys
Show/hide secret values
Save with validation (empty secrets filtered)

New behaviors:

Save/Discard buttons appear only when there are unsaved changes
Secrets load when switching projects in the dropdown
Warning prompt when switching projects with unsaved changes
MCP section's known secret keys update immediately after saving

Race condition fixes (Codex feedback):

Use useLayoutEffect for ref update to avoid stale import writes
Guard against empty projectPath during initial Settings render
Cancel stale imports when project changes
Reset isImporting state when project changes
Prompt for unsaved changes when deep-linking to project

Validation

Updated UI integration test to work with new Settings → Projects flow
Updated story: SecretsModalWithImport → ProjectSettingsWithSecrets
make static-check passes
Test passes: TEST_INTEGRATION=1 bun x jest tests/ui/secretsImport.integration.test.ts
Codex approved after addressing all review comments

Generated with mux • Model: anthropic:claude-opus-4-5 • Thinking: high • Cost: $15.53

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9760618e4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/SecretsModal.tsx

ammar-agent · 2026-02-03T21:56:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30646883f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/SecretsModal.tsx

ammar-agent · 2026-02-03T22:02:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebb7311056

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/SecretsModal.tsx

ammar-agent · 2026-02-04T00:09:52Z

@codex review

ammar-agent · 2026-02-04T00:12:01Z

@codex review

Addressed the previous race condition comment - the new ProjectSecretsSection now uses a ref to track the current project and cancels stale imports if the project changes during the async fetch.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da82e2fe2a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/Settings/sections/ProjectSecretsSection.tsx

ammar-agent · 2026-02-04T00:14:52Z

@codex review

ammar-agent · 2026-02-04T00:17:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ad4aa6cc9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

tests/ui/secretsImport.integration.test.ts

ammar-agent · 2026-02-04T00:20:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1faf0aca4e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/Settings/sections/ProjectSecretsSection.tsx

ammar-agent · 2026-02-04T00:24:57Z

@codex review

ammar-agent · 2026-02-04T00:25:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 945c2a37f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/Settings/sections/ProjectSecretsSection.tsx

ammar-agent · 2026-02-04T00:29:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcab0eb50a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/Settings/sections/ProjectSecretsSection.tsx

ammar-agent · 2026-02-04T00:33:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 380967f25e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/Settings/sections/ProjectSecretsSection.tsx

ammar-agent · 2026-02-04T00:39:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5620739b26

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/ProjectSidebar.tsx

ammar-agent · 2026-02-04T00:43:57Z

@codex review

chatgpt-codex-connector · 2026-02-04T00:48:39Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- Add 'Import from...' dropdown in the secrets modal that lists other projects - Fetch and merge secrets from selected source project - Skip existing keys (by uppercase comparison) to avoid overwriting - Add UI test to verify import behavior and key preservation

Address Codex review comment: use setSecrets((current) => ...) to avoid race conditions when user edits secrets while import is in-flight. Also improve test consistency: - Use setupTestDom() helper - Keep import './dom' for Radix bootstrap side effects

- Move 'Import from...' dropdown above the secrets list for better visibility - Add SecretsModalWithImport story to capture the feature visually - Story sets up two projects with secrets and opens the modal via play function

Address Codex review: prevent race where user clicks Save before import completes, which would close modal without persisting imported secrets.

- Create new ProjectSecretsSection component for inline secrets editing - Integrate secrets UI into ProjectSettingsSection with proper heading - Remove standalone SecretsModal component - Update ProjectSidebar key icon to open Settings → Projects (via openProjectSettings) - Tooltip changed from 'Manage secrets' to 'Project settings' - Update story: SecretsModalWithImport → ProjectSettingsWithSecrets - Update UI test to work with Settings modal flow The secrets UI now lives in Settings → Projects, keeping all project-level configuration in one place. Import from other projects still works the same way.

Add ref tracking to handleImportFromProject to discard results if the user switches projects while an import is in flight. Addresses Codex review comment about race condition.

- Replace KeyRound with Settings icon - Update aria-label from 'Manage secrets for X' to 'Settings for X' - Use standard hover colors instead of yellow - Update test and story selectors

The :has-text pseudo-class is Playwright-specific and throws in happy-dom.

Add onSecretsChanged callback to notify parent when secrets are saved, so MCP section's secret key validation reflects new keys immediately.

Ensures the ref is updated synchronously before any state updates in the same render cycle when project changes.

Return early when projectPath is empty to avoid: - Loading secrets for empty path during initial Settings render - Saving secrets to empty path if user somehow triggers save

Add confirmation prompt when user tries to switch projects in dropdown while secrets have unsaved changes, preventing accidental data loss.

When clicking sidebar settings button while modal is open, use handleProjectChange to trigger the confirmation prompt.

…workaround)

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

src/browser/components/SecretsModal.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

src/browser/components/SecretsModal.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

src/browser/components/SecretsModal.tsx Outdated Show resolved Hide resolved

ammar-agent changed the title ~~🤖 feat: import secrets from another project via modal~~ 🤖 feat: secrets management in Settings → Projects Feb 3, 2026

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

src/browser/components/Settings/sections/ProjectSecretsSection.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

tests/ui/secretsImport.integration.test.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

src/browser/components/Settings/sections/ProjectSecretsSection.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

src/browser/components/Settings/sections/ProjectSecretsSection.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

src/browser/components/Settings/sections/ProjectSecretsSection.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

src/browser/components/Settings/sections/ProjectSecretsSection.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

src/browser/components/ProjectSidebar.tsx Show resolved Hide resolved

ammar-agent force-pushed the secrets-v4jd branch from 0c91777 to eb5d1bb Compare February 4, 2026 02:02

ammar-agent added 4 commits February 4, 2026 10:11

fix: disable Save button while import is in flight

fcc6981

Address Codex review: prevent race where user clicks Save before import completes, which would close modal without persisting imported secrets.

ammar-agent added 16 commits February 4, 2026 10:11

fix: cancel stale imports when project changes

d22102a

Add ref tracking to handleImportFromProject to discard results if the user switches projects while an import is in flight. Addresses Codex review comment about race condition.

fix: reset isImporting when project changes

7bddc88

refactor: change secrets icon to settings icon

f237360

- Replace KeyRound with Settings icon - Update aria-label from 'Manage secrets for X' to 'Settings for X' - Use standard hover colors instead of yellow - Update test and story selectors

fix: use Testing Library query instead of :has-text selector

d74b6bc

The :has-text pseudo-class is Playwright-specific and throws in happy-dom.

fix: refresh projectSecretKeys after saving secrets

5e10412

Add onSecretsChanged callback to notify parent when secrets are saved, so MCP section's secret key validation reflects new keys immediately.

fix: use useLayoutEffect for projectPath ref to avoid race

699766a

Ensures the ref is updated synchronously before any state updates in the same render cycle when project changes.

fix: guard against empty projectPath in secrets section

26d82ba

Return early when projectPath is empty to avoid: - Loading secrets for empty path during initial Settings render - Saving secrets to empty path if user somehow triggers save

fix: warn before switching projects with unsaved secrets

63029d9

Add confirmation prompt when user tries to switch projects in dropdown while secrets have unsaved changes, preventing accidental data loss.

fix: prompt for unsaved secrets when deep-linking to project

b257860

When clicking sidebar settings button while modal is open, use handleProjectChange to trigger the confirmation prompt.

fix: avoid aria-label collision with global settings button

736e502

fix: handle MCP_TOKEN appearing in multiple inputs for storybook test

7002d68

fix: improve robustness of secrets import test

e5a5cd0

fix: wrap import click in act() for better CI stability

47e425d

fix: use native select in tests for secrets import (happy-dom portal …

fa84f7e

…workaround)

tests: stabilize secrets import integration test

b0a85e0

ammar-agent force-pushed the secrets-v4jd branch from 5fb093f to b0a85e0 Compare February 4, 2026 16:11

ammar-agent added 6 commits February 4, 2026 10:19

tests: ensure import select value is set

7a26c83

tests: harden secrets import select handling

34b3764

tests: make secrets import selection more robust

38bb98a

tests: expose secrets import helper for UI

6d1992b

tests: rely on secrets state helper for import

e6bd2e5

tests: persist imported secrets via state helper

f8289c7

Conversation

ammar-agent commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Implementation

Key behaviors preserved:

New behaviors:

Race condition fixes (Codex feedback):

Validation

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Feb 4, 2026

Uh oh!

ammar-agent commented Feb 3, 2026 •

edited

Loading