Skip to content

fix(inline-tool-link): use defaultValue to prevent selectionchange event#2993

Open
akulistus wants to merge 2 commits intonextfrom
fix-inline-popover-re-renders
Open

fix(inline-tool-link): use defaultValue to prevent selectionchange event#2993
akulistus wants to merge 2 commits intonextfrom
fix-inline-popover-re-renders

Conversation

@akulistus
Copy link
Contributor

@akulistus akulistus commented Feb 25, 2026

Problem:
Inline-popover re-renders constantly while text with link-tool formatting is selected.

Description:
Value assignment at line-215
causes a selectionchange event that triggers inline-popover re-render.

example 
<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8" />
  <title>selectionchange demo</title>
</head>
<body>
  <button id="valueBtn">Set value</button>
  <button id="defaultValueBtn">Set defaultValue</button>
  <br /><br />

  <input id="input" />

  <script>
    const input = document.getElementById('input');

    document.addEventListener('selectionchange', () => {
      console.log('selectionchange');
    });

    document.getElementById('valueBtn').onclick = () => {
      input.value = 'value text';
      console.log('value set');
    };

    document.getElementById('defaultValueBtn').onclick = () => {
      input.defaultValue = 'defaultValue text';
      console.log('defaultValue set');
    };
  </script>
</body>
</html>

Issue:
#2987

Solution:
Change input value assignment to defaultValue to prevent the selectionchange event.

@Evgenii-Zinner
Copy link

Evgenii-Zinner commented Mar 3, 2026 •
edited
Loading

This way when we use any tool on selected link, different button (bold or italic), we lose our link. This #2821 (comment) solution don't have this problem, while unlink button don't work this way either

@akulistus
Copy link
Contributor Author

akulistus commented Mar 3, 2026

Hello @Evgenii-Zinner!
Could you please provide an example of the described behavior and let me know which version of Editor.js you’re using? I tried to address this issue in version 2.31.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neSpecc neSpecc Awaiting requested review from neSpecc neSpecc is a code owner

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina TatianaFomina is a code owner

@ilyamore88 ilyamore88 Awaiting requested review from ilyamore88 ilyamore88 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akulistus @Evgenii-Zinner