Skip to content

Move allocation benchmark from example/ to bench/#223

Merged
sgerbino merged 1 commit intocppalliance:developfrom
sgerbino:pr/allocator-bench
Mar 9, 2026
Merged

Move allocation benchmark from example/ to bench/#223
sgerbino merged 1 commit intocppalliance:developfrom
sgerbino:pr/allocator-bench

Conversation

@sgerbino
Copy link
Collaborator

@sgerbino sgerbino commented Mar 9, 2026

The frame recycling allocator benchmark belongs with the other benchmarks. Build it as a separate target (boost_capy_bench_allocation) since it has its own main(). Mimalloc support remains conditional on BUILD_SHARED_LIBS.

Summary by CodeRabbit

  • Chores
    • Removed the allocation example from the build system configuration.

The frame recycling allocator benchmark belongs with the other
benchmarks. Build it as a separate target (boost_capy_bench_allocation)
since it has its own main(). Mimalloc support remains conditional on
BUILD_SHARED_LIBS.
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c02745c9-8788-4b07-a963-c99e653e7bae

📥 Commits

Reviewing files that changed from the base of the PR and between 6957c0f and 241853a.

⛔ Files ignored due to path filters (2)
  • bench/CMakeLists.txt is excluded by !**/bench/**
  • bench/allocation.cpp is excluded by !**/bench/**
📒 Files selected for processing (3)
  • example/CMakeLists.txt
  • example/allocation/CMakeLists.txt
  • example/allocation/Jamfile
💤 Files with no reviewable changes (3)
  • example/allocation/CMakeLists.txt
  • example/CMakeLists.txt
  • example/allocation/Jamfile

📝 Walkthrough

Walkthrough

This pull request removes the allocation example from the build system by deleting the CMake subdirectory reference in the example build configuration and removing both the CMake and Jam build scripts for the allocation example executable.

Changes

Cohort / File(s) Summary
Allocation Example Removal
example/CMakeLists.txt, example/allocation/CMakeLists.txt, example/allocation/Jamfile
Removes allocation example by eliminating the CMake subdirectory reference and deleting build configurations, including CMake target definition with conditional mimalloc integration and Boost Jam build script.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 ✨ A hop, a skip, we cleared the way,
Removed what once did build and play,
The allocation example gone,
Now simpler builds move on and on! 🚀

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving the allocation benchmark from example/ to bench/, which aligns with the PR's primary objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://223.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-03-09 22:41:46 UTC

@cppalliance-bot
Copy link

GCOVR code coverage report https://223.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://223.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://223.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-03-09 22:54:10 UTC

@sgerbino sgerbino merged commit 6f55745 into cppalliance:develop Mar 9, 2026
36 checks passed
@sgerbino sgerbino deleted the pr/allocator-bench branch March 9, 2026 23:02
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (8645de4) to head (241853a).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    92.14%   92.39%   +0.24%     
===========================================
  Files           77       81       +4     
  Lines         4534     4652     +118     
===========================================
+ Hits          4178     4298     +120     
+ Misses         356      354       -2     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8645de4...241853a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants