refactor(memory): convert memory classes to serializable#4761
Merged
greysonlalonde merged 4 commits intomainfrom Mar 9, 2026
Merged
refactor(memory): convert memory classes to serializable#4761greysonlalonde merged 4 commits intomainfrom
greysonlalonde merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
joaomdmoura
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Refactors core memory types (
Memory,MemoryScope,MemorySlice) to PydanticBaseModel, which can subtly change initialization/attribute semantics and impacts any code relying on the previous private_read_onlyflag or direct patching of instance methods.Overview
Memory refactor for serialization:
Memory,MemoryScope, andMemorySliceare converted to PydanticBaseModels with fields +model_post_init/validators to set up runtime-only dependencies (LLM/embedder/storage) while keeping instances serializable.API/behavior adjustments: replaces the private
_read_onlyflag with a publicread_onlyboolean (andMemoryScope.read_onlypassthrough), tightensdepthtyping toLiteral["shallow", "deep"], and updatesremember/tooling to no-op consistently whenread_only=True.Integration/test updates: agent memory save paths (
CrewAgentExecutorMixin,LiteAgent,create_memory_tools) now checkmemory.read_only, and tests patchMemorymethods at the class level to avoid Pydantic instance attribute restrictions while updating constructors to keyword-basedMemoryScope(memory=..., root_path=...)/MemorySlice(memory=..., scopes=...).Written by Cursor Bugbot for commit 6df5421. This will update automatically on new commits. Configure here.