allow setting grpc message sizes#34
Merged
bobh66 merged 4 commits intocrossplane-contrib:mainfrom Nov 27, 2025
Merged
Conversation
Signed-off-by: Matej Ohradzansky <[email protected]>
Signed-off-by: Matej Ohradzansky <[email protected]>
ezgidemirel
reviewed
Nov 24, 2025
pyproject.toml
Outdated
Comment on lines
120
to
121
| [tool.ruff.lint.pylint] | ||
| max-args = 6 |
There was a problem hiding this comment.
instead of allowing 6 parameters in general, we can just extend the noqa codes of the cli function like
# noqa: FBT001, PLR0913
Member
There was a problem hiding this comment.
I agree. I'd prefer to make a one-time exception for the specific cli function.
ezgidemirel
approved these changes
Nov 24, 2025
ezgidemirel
left a comment
There was a problem hiding this comment.
thanks for the PR @P0t4T0o, added a single comment but the rest looks good
Signed-off-by: Matej Ohradzansky <[email protected]>
0a43bbe to
cbf8872
Compare
- function sdk 0.10.0 - grpcio 1.76.0 Signed-off-by: Matej Ohradzansky <[email protected]>
Contributor
Author
|
Hi @ezgidemirel, thank you for the review. |
bobh66
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #33
Depends on: crossplane/function-sdk-python#188
I have:
[ ] Added or updated unit tests for my change.Tested with crank render:
python main.py --debug --insecure --max-recv-message-size 3 --max-send-message-size 3python main.py --debug --insecure --max-recv-message-size 4 --max-send-message-size 4