DAOS-18597 bio: allow SPDK reinitialization#17614
Open
Conversation
Ref: spdk/spdk@fba209c Ref: #16774 Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
requested review from
Nasf-Fan and
NiuYawei
and removed request for
a team
|
Ticket title is 'ddb dev_list with --vos_path in interactive mode causes segmentation fault' |
Collaborator
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17614/1/testReport/ |
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Nasf-Fan
approved these changes
Mar 2, 2026
| * SPDK multiple times within the same process, for example when inspecting multiple pools | ||
| * sequentially. For those use cases, the RPC state must now be reset explicitly. | ||
| */ | ||
| spdk_rpc_set_state(SPDK_RPC_STARTUP); |
Contributor
There was a problem hiding this comment.
Maybe move it after init_arg allocation?
Contributor
Author
There was a problem hiding this comment.
I chose this location deliberately because:
- It is next to the
spdk_subsystem_load_config()which calledspdk_rpc_set_state()previously. - But before anything related to
init_argso the preparation of the argument for thespdk_subsystem_load_config()remains undisturbed.
knard38
approved these changes
Mar 4, 2026
Contributor
knard38
left a comment
knard38
left a comment
There was a problem hiding this comment.
LGTM
I have manually tested the proposed patch with success.
Contributor
|
remove gatekeeper till merge approval |
Contributor
|
@NiuYawei since you own most of bio, can you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: spdk/spdk@fba209c
Ref: #16774
Steps for the author:
After all prior steps are complete: