Add more server-side defaults to config sync#4534
Merged
ilyakuz-db merged 13 commits intomainfrom Feb 18, 2026
Merged
Conversation
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 89be85c
8 interesting tests: 6 SKIP, 2 RECOVERED
Top 4 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 6484d9a
11 interesting tests: 6 SKIP, 3 flaky, 2 RECOVERED
Top 33 slowest tests (at least 2 minutes):
|
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
changed the title
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
ilyakuz-db
commented
Feb 18, 2026
| "resources.jobs.*.job_clusters[*].new_cluster.single_user_name": alwaysSkip, | ||
|
|
||
| // Standalone cluster fields | ||
| "resources.clusters.*.aws_attributes": alwaysSkip, |
Contributor
Author
There was a problem hiding this comment.
Hardcoded for now, will migrate this to using bundle_plan field checker in next PRs
denik
approved these changes
Feb 18, 2026
denik
reviewed
Feb 18, 2026
| } | ||
|
|
||
| if cluster.DataSecurityMode == "" { | ||
| cluster.DataSecurityMode = compute.DataSecurityModeSingleUser |
Contributor
There was a problem hiding this comment.
I haven't seen this happening on bundle/invariant/no_drift, so maybe there is a condition missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
That was something that appeared in config-remote-sync when I tested it with different bundles
Tests
Updated test-server, added more resources in acceptance tests