refactor(chat): decouple visible session from live socket runtime in AgentDetail#152
Open
Congregalis wants to merge 2 commits intodataelement:mainfrom
Open
refactor(chat): decouple visible session from live socket runtime in AgentDetail#152Congregalis wants to merge 2 commits intodataelement:mainfrom
Congregalis wants to merge 2 commits intodataelement:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to the session-switching bugfix work (#144 / #151).
It separates UI visibility from per-session chat runtime in
AgentDetail.tsx, so switching sessions/agents no longer relies on a single global socket lifecycle.Problem
AgentDetailpreviously treated:as the same lifecycle.
That coupling made session switching fragile and caused issues such as:
What changed
1) Per-session runtime management
agentId:sessionId.2) Session message load race protection
AbortController+ sequence checks inselectSession().3) Unified session-switch behavior
createNewSession()now reuses session selection flow instead of ad-hoc state resets.4) Active-session scoped send/stop actions
5) Preserve “thinking/waiting” state across switches
isWaiting/isStreaming.Scope / Non-goals
This PR focuses on stabilizing in-page session/agent switching behavior in
AgentDetail.It does not introduce a full background execution/job model across page reloads.
Validation
Manual checks performed:
Files changed
frontend/src/pages/AgentDetail.tsxChecklist