Make flaky connection-type tests more lenient#1643
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Conversation
Depending on the situation, an intended UDS connection can fall back to a TCP/IP connection, so the status == UDS test can fail. Assuming the inverse is true, make TCP/IP and UDS status-text checks each depend on whether the "unix_socket" property is actually set on the connection. This evades one purpose of the tests, but still tests the text in the status output. An alternative could be to delete the flaky tests entirely.
|
Findings
No direct security issues found in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depending on the situation, an intended UDS connection can fall back to a TCP/IP connection, so the status == UDS test can fail.
Assuming the inverse is true, make TCP/IP and UDS status-text checks each depend on whether the
unix_socketproperty is actually set on the connection. This evades one purpose of the tests, but still tests the text in thestatusoutput.An alternative could be to delete the flaky tests entirely.
These tests are a problem in my local, but not failing in CI.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).