dbeaver/pro#7657 avoid blicking by debounce loading state#4174
Open
dbeaver/pro#7657 avoid blicking by debounce loading state#4174
Conversation
Wroud
reviewed
Feb 26, 2026
Member
|
in general, if loader mounted with loading state it should immediately display loading state, if loader changed state to the loading state it should delay it |
Member
Author
yes, it works that way now |
SychevAndrey
requested changes
Feb 27, 2026
Comment on lines
+25
to
+26
| internalCallbackRef.current = callback; | ||
| delayRef.current = delay; |
Contributor
There was a problem hiding this comment.
we should not update refs during render, as we have discussed that before. You can read or write refs from event handlers or effects instead.
Wroud
reviewed
Mar 2, 2026
Wroud
approved these changes
Mar 3, 2026
sergeyteleshev
approved these changes
Mar 3, 2026
SychevAndrey
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes 7657
delay showing
instant hiding