send correct message value for comment event, add more types of comment event#39
Open
JeffZhang02747 wants to merge 119 commits intodebugger22:masterfrom
Open
send correct message value for comment event, add more types of comment event#39JeffZhang02747 wants to merge 119 commits intodebugger22:masterfrom
JeffZhang02747 wants to merge 119 commits intodebugger22:masterfrom
Conversation
Add a feature to filter out events of specified repos/orgs
added some details to README
The GitHub API doesn't actually return `action = merged' when a PR is merged; it just sets `pull_request.merged = true'. From the Description field for the Action key: https://developer.github.com/v3/activity/events/types/#pullrequestevent
With this commit each event has a proper link directing to the actual event, except PushEvents which direct to the repo since there isn't any available link to the commits.
Mixed improvements on server and client
Add missing commas
Change project name and add a disclaimer as suggested by GitHub
Owner
|
I'll test it locally and then let you know. |
debugger22
force-pushed
the
master
branch
2 times, most recently
from
872e658 to
e5d1bb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will issue #38 .
Reason why commentEvent are not displayed and played sound is that, data.body is NULL,
passing data.payload.comment.body instead.
handle PullRequestReviewCommentEvent and CommitCommentEvent as commentEvent.
update html accordingly.