Conversation
|
Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + tools#482" |
thewilsonator
left a comment
There was a problem hiding this comment.
You typo'd the commit title and PR title. I fixed the PR title, please fix the commit title.
a51571a changed the help text output leading leading to test failures Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
7964dbb to
6b1e240
Compare
Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
2730464 to
b0fa2d6
Compare
Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
39bb436 to
52ea53d
Compare
|
Is it possible to enable the workflow to run every time? Currently |
|
c39bd46 is fixing a current test failure, should it be targeting stable? |
Maybe? It is not run by default for first-time contributors (which you are for this repo), so I am manually approving it.
It could, I don't see any harm in doing so. |
Not doing it would mean that |
|
yes |
|
nvm, |
|
Is this good to go? If not, ping me when it is |
|
Fine with me |
No description provided.