fix: content drive clean-up - animation, loading states, and type fixes#34784
Merged
zJaaal merged 9 commits intoissue-33882-primeng-updatefrom Feb 27, 2026
Merged
Conversation
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0
|
...portlets/dot-content-drive/ui/src/lib/dot-folder-list-view/dot-folder-list-view.component.ts
Outdated
Show resolved
Hide resolved
...ortlet/src/lib/components/dot-content-drive-toolbar/dot-content-drive-toolbar.component.html
Outdated
Show resolved
Hide resolved
KevinDavilaDotCMS
approved these changes
Feb 26, 2026
dario-daza
approved these changes
Feb 26, 2026
oidacra
reviewed
Feb 26, 2026
...portlets/dot-content-drive/ui/src/lib/dot-folder-list-view/dot-folder-list-view.component.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Feb 26, 2026
...rtlets/dot-content-drive/ui/src/lib/dot-folder-list-view/dot-folder-list-view.component.html
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Feb 26, 2026
...ortlet/src/lib/components/dot-content-drive-toolbar/dot-content-drive-toolbar.component.html
Outdated
Show resolved
Hide resolved
oidacra
approved these changes
Feb 26, 2026
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@slideAnimationtrigger with CSS-basedanimate.enter/animate.leaveattributes to remove the deprecated@angular/animationsdependency from the toolbar component@if) to CSS-based show/hide (opacity/visibility/width) so the toggle button animates smoothly instead of popping in/outloadingRowinto a reusable<ng-template>and show it insideemptymessageduring loading so rows appear correctly on initial load and page changes$loadingRowssignal to track the current page size and emit correctly sized skeleton row arrays on pagination$dialogsignal calls in the shell component to prevent null-access errors$folderinput type fromnulldefault toundefined(aligns with Angular signal input best practices)Screen.Recording.2026-02-26.at.12.05.11.PM.mov
Test plan
yarn nx test dot-content-drive-portletand confirm all passyarn nx test dot-content-drive-uiand confirm all pass🤖 Generated with Claude Code
This PR fixes: #34108