Skip to content

fix: content drive clean-up - animation, loading states, and type fixes#34784

Merged
zJaaal merged 9 commits intoissue-33882-primeng-updatefrom
issue-34108-content-drive-clean-up
Feb 27, 2026
Merged

fix: content drive clean-up - animation, loading states, and type fixes#34784
zJaaal merged 9 commits intoissue-33882-primeng-updatefrom
issue-34108-content-drive-clean-up

Conversation

@zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Feb 26, 2026

Summary

  • Replace Angular @slideAnimation trigger with CSS-based animate.enter/animate.leave attributes to remove the deprecated @angular/animations dependency from the toolbar component
  • Change toolbar tree-toggler visibility from conditional rendering (@if) to CSS-based show/hide (opacity/visibility/width) so the toggle button animates smoothly instead of popping in/out
  • Fix folder list view loading skeleton: extract loadingRow into a reusable <ng-template> and show it inside emptymessage during loading so rows appear correctly on initial load and page changes
  • Update $loadingRows signal to track the current page size and emit correctly sized skeleton row arrays on pagination
  • Fix optional chaining on $dialog signal calls in the shell component to prevent null-access errors
  • Fix $folder input type from null default to undefined (aligns with Angular signal input best practices)
  • Fix typing errors and update tests to match new DOM structure (toggler now always rendered, assertions check styles rather than element presence)
Screen.Recording.2026-02-26.at.12.05.11.PM.mov

Test plan

  • Navigate to Content Drive portlet and verify the folder list renders skeleton loading rows on initial load
  • Verify that changing pages shows the correct number of skeleton rows matching the page size
  • Expand/collapse the folder tree panel and verify the tree-toggler button animates smoothly (fades rather than snapping in/out)
  • Click "Add New" and verify the toolbar button animates in/out when switching between normal and multi-selection mode
  • Open a dialog (e.g., create folder), verify it opens and closes correctly without null-reference errors
  • Run unit tests: yarn nx test dot-content-drive-portlet and confirm all pass
  • Run unit tests for the UI lib: yarn nx test dot-content-drive-ui and confirm all pass

🤖 Generated with Claude Code

This PR fixes: #34108

@semgrep-code-dotcms-test
Copy link

Legal Risk

The following dependencies were released under a license that
has been flagged by your organization for consideration.

Recommendation

While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.

MPL-2.0

@zJaaal zJaaal merged commit 6298668 into issue-33882-primeng-update Feb 27, 2026
6 checks passed
@zJaaal zJaaal deleted the issue-34108-content-drive-clean-up branch February 27, 2026 13:03
@semgrep-code-dotcms-test
Copy link

Legal Risk

The following dependencies were released under a license that
has been flagged by your organization for consideration.

Recommendation

While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.

MPL-2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : Frontend PR changes Angular/TypeScript frontend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[DEFECT] Content Drive table shows "no content found" instead of "loading" screen when loading

4 participants