This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Adding Update, Exclude, and Remove everywhere they currently are not.#71
Open
cdonnellytx wants to merge 1 commit intodotnet:mainfrom
Open
Adding Update, Exclude, and Remove everywhere they currently are not.#71cdonnellytx wants to merge 1 commit intodotnet:mainfrom
cdonnellytx wants to merge 1 commit intodotnet:mainfrom
Conversation
|
|
This fixes dotnet#68, at least the ArgumentNullException part -- targets files without an Sdk attribute don't seem to work.
cdonnellytx
force-pushed
the
dev/cdonnellytx/UpdateExcludeRemoveEverywhere
branch
from
fb82f2a to
ccb051f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #68, at least that it no longer throws an
ArgumentNullExceptionwhen the element uses Update, Remove, or Exclude.Known issues
.targetsfiles without anSdkattribute still don't seem to trigger code completion, but I'm not sure why. I'll probably open a separate bug for this unless someone knows why that would be the case.