Fix slow tests by adding IAcrImageImporter abstraction#1996
Open
lbussell wants to merge 2 commits intodotnet:mainfrom
Open
Fix slow tests by adding IAcrImageImporter abstraction#1996lbussell wants to merge 2 commits intodotnet:mainfrom
IAcrImageImporter abstraction#1996lbussell wants to merge 2 commits intodotnet:mainfrom
Conversation
lbussell
changed the title
IAcrRegistryImporter abstractionIAcrImageImporter abstraction
mthalman
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git bisectfound that #1975 caused ImageBuilder's test to slow down dramatically, increasing from ~3 seconds to 100+ seconds.The test
ImportImageAsync_ExternalSourceRegistry_DoesNotRequireSourceRegistryInPublishConfigcallsCopyImageService.ImportImageAsyncwithisDryRun: false, which hits real ARM SDK methods through a mockedTokenCredential. Each call fails andRetryHelperretries 5 times with backoff as well, causing that single test to take over one minute.This PR adds an abstraction for the ARM client which
CopyImageServiceresolves via DI so that the test can mock it. All 424 tests now pass in ~5 seconds.