Move Uri tests from System.Runtime to System.Private.Uri and consolidate ExtendedFunctionalTests #123764
+187
−692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate ExtendedFunctionalTests Co-authored-by: MihaZupan <[email protected]>
Copilot
AI
changed the title
[WIP] Move Uri-related tests to System.Private.Uri functional tests
Move Uri tests from System.Runtime to System.Private.Uri and consolidate ExtendedFunctionalTests
Jan 29, 2026
MihaZupan
approved these changes
Jan 29, 2026
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
Assuming CI is happy, LGTM
@dotnet/ncl Uri tests existed across 4 projects:
- Unit/Functional/ExtendedFunctional test projects under System.Private.Uri
- A couple files in System.Runtime.Tests
This PR moves tests from System.Runtime and ExtendedFunctional into the regular functional tests project, making it so we just have two.
This is really just to make inner-loop less annoying for myself when looking at Uri locally since I can run all tests from a single project.
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates all System.Uri-related tests under System.Private.Uri/tests/FunctionalTests, removing the split coverage previously living in System.Runtime.Tests and eliminating the now-redundant ExtendedFunctionalTests project.
Changes:
- Removed Uri-specific test file inclusions from
System.Runtime.Tests.csproj. - Added moved Uri test files (
UriCreateStringTests,UriCreateUriTests,UriMethodsTests) intoSystem.Private.UriFunctionalTests and updated their namespaces. - Merged the remaining unique ExtendedFunctionalTests cases into
FunctionalTests/UriTests.csand removed the ExtendedFunctionalTests project/files.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System.Runtime.Tests.csproj | Removes compilation of the Uri-specific tests from System.Runtime test project. |
| src/libraries/System.Private.Uri/tests/FunctionalTests/System.Private.Uri.Functional.Tests.csproj | Adds the moved Uri test sources to the System.Private.Uri functional test project. |
| src/libraries/System.Private.Uri/tests/FunctionalTests/UriCreateStringTests.cs | Namespace update to align with System.Private.Uri test conventions after move. |
| src/libraries/System.Private.Uri/tests/FunctionalTests/UriCreateUriTests.cs | Namespace update to align with System.Private.Uri test conventions after move. |
| src/libraries/System.Private.Uri/tests/FunctionalTests/UriMethodsTests.cs | Namespace update to align with System.Private.Uri test conventions after move. |
| src/libraries/System.Private.Uri/tests/FunctionalTests/UriTests.cs | Incorporates the previously-extended functional/obsolete API test cases into the consolidated functional test suite. |
| src/libraries/System.Private.Uri/tests/ExtendedFunctionalTests/System.Private.Uri.ExtendedFunctional.Tests.csproj | Removes the ExtendedFunctionalTests project. |
| src/libraries/System.Private.Uri/tests/ExtendedFunctionalTests/UriTests.cs | Removes the now-merged ExtendedFunctionalTests source file. |
| src/libraries/System.Private.Uri/tests/ExtendedFunctionalTests/UriRelativeResolutionTest.cs | Removes the duplicate ExtendedFunctionalTests relative resolution tests. |
Member
|
@copilot fix the references in the NlsTest project |
Co-authored-by: MihaZupan <[email protected]>
auto-merge was automatically disabled
January 29, 2026 21:18
Head branch was pushed to by a user without write access
Contributor
Author
MihaZupan
approved these changes
Jan 30, 2026
This was referenced Jan 30, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uri tests were split between
System.Private.Uri/testsandSystem.Runtime/tests. This consolidates all Uri-related tests intoSystem.Private.Uri/tests/FunctionalTests.Changes
Moved from System.Runtime/tests:
Uri.CreateStringTests.cs→UriCreateStringTests.csUri.CreateUriTests.cs→UriCreateUriTests.csUri.MethodsTests.cs→UriMethodsTests.csSystem.TeststoSystem.PrivateUri.TestsConsolidated ExtendedFunctionalTests:
FunctionalTests/UriTests.csExtendedFunctionalTests/UriRelativeResolutionTest.cs(complete duplicate)Project file updates:
System.Private.Uri.Functional.Tests.csprojSystem.Runtime.Tests.csprojSystem.Runtime.Nls.Tests.csprojAll 15,221 tests pass in the consolidated project.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.