Change/upgraded to react18 CMEM-6639 #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/cmem/ContentBlobToggler/StringPreviewContentBlobToggler.tsx
haschek
requested changes
Feb 5, 2026
| danger: EdgeBezier, | ||
| }; | ||
|
|
||
| const nodeTypes: Record<GRAPH_NODE_TYPES, React.ReactNode /*& ComponentType<NodeProps>*/> = { |
Member
There was a problem hiding this comment.
We need to check this change from the LTS version because this is used for both supported react flow versions.
| danger: EdgeStep, | ||
| }; | ||
|
|
||
| const nodeTypes: Record<LINKING_NODE_TYPES, React.ReactNode /*& ComponentType<NodeProps>*/> = { |
| danger: EdgeStep, | ||
| }; | ||
|
|
||
| const nodeTypes: Record<WORKFLOW_NODE_TYPES, React.ReactNode /*& ComponentType<NodeProps>*/> = { |
| children: React.ReactNode; | ||
| className?: string; | ||
| onToggle?: any //todo change later | ||
| } |
Member
There was a problem hiding this comment.
Looks like a hack, also React.HTMLAttributes<HTMLElement> was taken out. We need to check for the reasons.
| : depiction instanceof HTMLElement | ||
| ? <>{depiction.outerHTML}</> | ||
| : depiction} | ||
| </span> |
Member
There was a problem hiding this comment.
Why should land a HTMLElement here?
| const originalChild = child as React.ReactElement; | ||
| if (originalChild && originalChild.type && originalChild.type === PropertyValuePair) { | ||
| return React.cloneElement(originalChild, { singleColumn: true }); | ||
| return React.cloneElement(originalChild as React.ReactElement<{singleColumn: boolean}>, { singleColumn: true }); |
Member
There was a problem hiding this comment.
Type i set earlier, why need this be overwritten here?
| const originalChild = child as React.ReactElement; | ||
| if (originalChild.type && (originalChild.type === PropertyName || originalChild.type === PropertyValue)) { | ||
| return React.cloneElement(originalChild, { nowrap: true }); | ||
| return React.cloneElement(originalChild as React.ReactElement<{nowrap: boolean}>, { nowrap: true }); |
| ({ children, edgeCenter, resizeTimeout = -1, ...otherForeignObjectProps }: EdgeLabelObjectProps) => { | ||
| const containerCallback = React.useCallback( | ||
| (containerRef) => { | ||
| (containerRef:any) => { |
Member
There was a problem hiding this comment.
There is probably another type for refs.
| }; | ||
|
|
||
| const onResize = React.useCallback((_0, _1, _2, d) => { | ||
| const onResize = React.useCallback((_0:any, _1:any, _2:any, d:any) => { |
Member
There was a problem hiding this comment.
Should be probably the same like in line 759?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made refactors to adapt for version 18 and even version 19.