Skip to content

various fixes#420

Merged
MaximilianSoerenPollak merged 1 commit intomainfrom
various
Feb 25, 2026
Merged

various fixes#420
MaximilianSoerenPollak merged 1 commit intomainfrom
various

Conversation

@AlexanderLanin
Copy link
Member

extracted from #411

as these fixes can be merged without further discussion?

@github-actions
Copy link

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 1d8ab4fc-b0df-40b7-8bc6-34d07f578822
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (57 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (81 packages loaded, 17 targets configured)

Analyzing: target //src:license-check (127 packages loaded, 1670 targets configured)

Analyzing: target //src:license-check (135 packages loaded, 2205 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (143 packages loaded, 4465 targets configured)

INFO: Analyzed target //src:license-check (145 packages loaded, 4715 targets configured).
[1 / 1] no actions running
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 22.328s, Critical Path: 2.69s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bundles a set of small fixes extracted from #411, primarily to improve non-Bazel Python execution (via bazel-runfiles), clean up some Bazel BUILD loads, and adjust dev tooling/scripts.

Changes:

  • Add bazel-runfiles to Python requirements and switch runfiles import path in helper_lib.
  • Simplify/clean up Bazel BUILD files (remove unused loads; add java_binary load where needed).
  • Minor maintenance updates to the link-check action script and devcontainer image tag.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/requirements.txt Adds pinned bazel-runfiles with hash to the lockfile.
src/requirements.in Adds bazel-runfiles as a top-level input dependency (with a new comment).
src/helper_lib/__init__.py Switches runfiles import to from runfiles import Runfiles.
src/extensions/BUILD Removes unused Bazel load() statements.
src/BUILD Adds java_binary load (used for the PlantUML target).
.github/actions/link-check/link_parser.py Small string/formatting simplifications and avoids shadowing argparse.
.devcontainer/devcontainer.json Updates devcontainer image tag.
Comments suppressed due to low confidence (2)

src/requirements.in:35

  • Typo in comment: "exectuion" -> "execution" (and consider "non-Bazel" for clarity).
# Need this to enable non bazel exectuion
bazel-runfiles

.github/actions/link-check/link_parser.py:91

  • For consistency with other scripts (e.g. src/incremental.py), consider naming the ArgumentParser variable parser rather than arg (it reads like a single CLI argument rather than the parser itself).
    arg = argparse.ArgumentParser(
        description="Parse broken links from Sphinx log and generate issue body."
    )
    arg.add_argument("logfile", type=str, help="Path to the Sphinx log file.")
    args = arg.parse_args()

from pathlib import Path

from python.runfiles import Runfiles
from runfiles import Runfiles
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helper_lib's Bazel target depends on @rules_python//python/runfiles (which provides python.runfiles), so switching to from runfiles import Runfiles will break Bazel executions unless the pip bazel-runfiles requirement is also added as a Bazel dep. Consider a compatibility import (try python.runfiles first, fall back to runfiles) or update the Bazel deps to match this import path.

Suggested change
from runfiles import Runfiles
try:
# Preferred in Bazel environments using @rules_python//python/runfiles
from python.runfiles import Runfiles
except ImportError:
try:
# Fallback for environments using the pip 'bazel-runfiles' package
from runfiles import Runfiles
except ImportError:
Runfiles = None # type: ignore[assignment]

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit f8e0176 into main Feb 25, 2026
18 checks passed
@MaximilianSoerenPollak MaximilianSoerenPollak deleted the various branch February 25, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants