Skip to content

feat(admin-api): add list table revisions endpoint#1744

Open
shiyasmohd wants to merge 1 commit intomainfrom
shiyasmohd/list-revisions
Open

feat(admin-api): add list table revisions endpoint#1744
shiyasmohd wants to merge 1 commit intomainfrom
shiyasmohd/list-revisions

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Feb 12, 2026

  • Add GET /revisions to list all physical table revisions. Supports ?active=(true/false) filter

Example Output

[
  {
    "id": 3,
    "path": "mainnet/logs/019c5ac2-bec6-7ea1-86b1-99ede8b154ec",
    "active": true,
    "writer": 1,
    "metadata": {
      "dataset_namespace": "s",
      "dataset_name": "mainnet",
      "manifest_hash": "3653ba10dced7e02241c92d921e7ec94b587d9c1718839588cbb88fee8e9f2b1",
      "table_name": "logs"
    }
  }
]

@shiyasmohd shiyasmohd requested a review from LNSD February 12, 2026 12:23
@shiyasmohd shiyasmohd self-assigned this Feb 12, 2026
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/list-revisions branch from 5a96262 to ddce242 Compare February 12, 2026 12:31
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current endpoint GET /revisions/{namespace}/{name}/{revision}/{table_name} introduces unnecessary complexity.

I would suggest replacing it with a simple GET /revisions that lists all physical table revisions directly, with no dataset join needed.

This aligns naturally with the existing revision endpoints:

GET  /revisions                  <- list all (new)
POST /revisions/{id}/activate    <- existing
POST /revisions/{id}/deactivate  <- existing

If filtering is needed, query parameters are the natural fit:

GET /revisions
GET /revisions?active=true  <- Return only the active revisions

@shiyasmohd shiyasmohd force-pushed the shiyasmohd/list-revisions branch from ddce242 to 331088c Compare February 14, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants