Open
Conversation
jeremypw
approved these changes
Feb 12, 2026
Contributor
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Even though ensure_sizer () is called repeatedly during loading of files, I did see of significant change in loading time for folders containing 5000 items so presumably the Settings backend caches the setting anyway.
Contributor
|
The CI passed locally, but failed on GitHub because the schema is not installed. |
Member
Author
|
Hm I'm not sure how to resolve this. I'll revisit with more coffee maybe. At least this exposes a problem with FilesPreferences being in core but the actual gsettings being set elsewhere 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get settings directly from gsettings instead of an intermediary object