Open
Conversation
RMcNeely
reviewed
Mar 10, 2026
Contributor
RMcNeely
left a comment
RMcNeely
left a comment
There was a problem hiding this comment.
I'm not sure that this will always fix everything, couldn't it still be resolving while someone hits the download link? Seems like we need check the promise is resolved first before we pass the data in. That said I'm not sure if this is a realistic worry and if it's broken now its probably best to just fix it this way.
lewisgoddard
force-pushed
the
fix-architecture-tracking
branch
from
a48b7d9 to
c397bdb
Compare
lewisgoddard
force-pushed
the
fix-architecture-tracking
branch
from
c397bdb to
d5853e0
Compare
Member
Author
|
@RMcNeely I've changed it to use class based tracking like magnet and http, no async methods at all. Not sure why we were trying to track the viewers architecture when the download tracking tracks the download attributes for everything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous.js, it was never being used.await detectedArchitecture()to CSS class checks (arm/x86) on the download links, eliminating the async click handler issue.This pull request is ready for review.