Fix Enum.slice deprecation warning in parse_udp#176
Merged
josevalim merged 2 commits intoelixir-ecto:masterfrom Nov 24, 2025
Merged
Fix Enum.slice deprecation warning in parse_udp#176josevalim merged 2 commits intoelixir-ecto:masterfrom
josevalim merged 2 commits intoelixir-ecto:masterfrom
Conversation
Replace deprecated Enum.slice(0..-2//-1) syntax with Enum.slice(0..-2//1) to fix warning in Elixir 1.18: warning: negative steps are not supported in Enum.slice/2, pass 0..-2//1 instead This warning appears in lib/tds/protocol.ex:394 when connecting to SQL Server instances via UDP for instance discovery. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
josevalim
reviewed
Nov 24, 2025
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_udp/2Enum.slice(0..-2//-1)withEnum.slice(0..-2//1)Issue
When connecting to SQL Server instances via UDP for instance discovery, users see this warning in Elixir 1.18:
Changes
lib/tds/protocol.exto use the correct range syntaxTest plan
🤖 Generated with Claude Code