Fix Client PID encoding in Login7 structure (#180)#181
Merged
mjaric merged 1 commit intoelixir-ecto:masterfrom Feb 25, 2026
Merged
Fix Client PID encoding in Login7 structure (#180)#181mjaric merged 1 commit intoelixir-ecto:masterfrom
mjaric merged 1 commit intoelixir-ecto:masterfrom
Conversation
The `dword()` encoding type was configured to use big endian instead of little endian. It is only used for the PID and a zero value in this module. Additionally, this replaces the Tds.Protocol.Login7.pid! implementation with one that uses System.pid() instead of the internal erlang runtime pid, for better parity with other SQL Server clients. Also adds a test case for this.
mjaric
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dword()encoding type was configured to use big endian instead of little endian. It is only used for the PID and a zero value in this module.Additionally, this replaces the Tds.Protocol.Login7.pid! implementation with one that uses System.pid() instead of the internal erlang runtime pid, for better parity with other SQL Server clients.
Also adds a test case for this.