ci: Fix attaching linux metadata to release#2063
Merged
Conversation
Member
Author
|
I intend to test this as follows:
|
|
Test build no longer available. |
wjt
force-pushed
the
wjt/ci-fix-attaching-linux-metadata-to-release
branch
3 times, most recently
from
5c10cfd to
b43f4f5
Compare
Member
Author
|
https://github.com/endlessm/threadbare/releases/tag/v0.1.11%2Btest3 demonstrates that this works |
In commit 01429b1 I took advantage of a new feature in actions/upload-artifact to upload the .tar.gz file without wrapping it in a .zip file. However I did not update the release step to match. Fix this. Rework the release step so that it downloads everything first, renames as needed, then uploads all appropriately-named files. Don't unpack the whole web artifact and re-pack it: use the new skip-decompress flag to get the .zip file, and attach that directly to the release. Factor out setting GITHUB_TOKEN in the environment. Resolves #2062
wjt
force-pushed
the
wjt/ci-fix-attaching-linux-metadata-to-release
branch
from
b43f4f5 to
3afb676
Compare
Member
Author
|
Once merged I will delete the pre-release to remove an unnecessary build from the amalgamation. |
manuq
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 01429b1 I took advantage of a
new feature in actions/upload-artifact to upload the .tar.gz file
without wrapping it in a .zip file.
However I did not update the release step to match. Fix this.
Rework the release step so that it downloads everything first,
then uploads. Don't unpack the whole web artifact and re-pack it: use
the new skip-decompress flag to get the .zip file, and attach that
directly to the release.
Factor out setting GITHUB_TOKEN in the environment.
Resolves #2062