Open
Conversation
Collaborator
Author
|
This works but is draft for now because StoryQuests have to be maintained, as a quick grep shows: |
|
Play this branch at https://play.threadbare.game/branches/endlessm/player-input/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Keep slowing down the player while the grappling hook is being used. For this, add a new aiming_changed signal to the PlayerHook. Also use the running_changed signal of InputWalkBehavior instead of checking constantly for: - Emitting the dust particles. - Doubling the frame-by-frame animation speed or using a special run animation.
Adapt to the speeds change. Also these instances have editable children to hide and disable the dust particles, but the node in that position is now the InputWalkBehavior, so switch it back to enabled and disable the dusts (2nd node) instead. Also remove mode=1 from players, because now that means "system controlled".
Adapt to the speeds change.
Because now that means "system controlled".
Collaborator
Author
|
This also fixes scenes which had Player mode still set to 1, which now means "system controlled". Ouch. It could be a separate PR but I did it here directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep slowing down the player while the grappling hook is being used. For this, add a new aiming_changed signal to the PlayerHook.
Also use the running_changed signal of InputWalkBehavior instead of checking constantly for:
Adapt the scenes and scripts in StoryQuests that had the player speeds set.
Resolve #1151