refactor(settings): move translator to pydantic settings#221
Open
crankynetman wants to merge 3 commits intomainfrom
Open
refactor(settings): move translator to pydantic settings#221crankynetman wants to merge 3 commits intomainfrom
crankynetman wants to merge 3 commits intomainfrom
Conversation
|
Pytest Celery Scheduler Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 107a395 |
|
Django Pytest/Behave Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 107a395 |
samoehlert
reviewed
Mar 4, 2026
| gobgp_host: str = "gobgp" | ||
| gobgp_port: TCPUDPPort = 50051 | ||
|
|
||
| @computed_field |
Collaborator
There was a problem hiding this comment.
is this just because we're building the URL via multiple variables?
samoehlert
reviewed
Mar 4, 2026
| # check to make sure that this is actually a valid websocket URL | ||
| parsed_url = AnyWebsocketUrl(v) | ||
| # then make sure that the trailing slash is actually there. | ||
| if not (parsed_url.path and parsed_url.path.endswith("/")): |
Collaborator
There was a problem hiding this comment.
does this point to us doing something dumb with our websocket URLs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #48 and gives us nice clean pydantic settings for all the validation of our translator settings, the same as
schedulerdoes.