feat(pushsync): add metrics tracking to chunks and light-chunks modes#573
Merged
gacevicljubisa merged 1 commit intomasterfrom Mar 9, 2026
Merged
Conversation
akrem-chabchoub
approved these changes
Mar 6, 2026
Contributor
akrem-chabchoub
left a comment
akrem-chabchoub
left a comment
There was a problem hiding this comment.
Nice, How we can see the results ?
Member
Author
Metrics were not avialable for other modes except "default". Now we can gather them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add upload counter, upload time gauge/histogram, and synced/not-synced counters to checkChunks and checkLightChunks, matching the existing metrics instrumentation in the default check mode.