Skip to content

feat(feed): add duration metrics for feed updates, retrieval, and availability in v1 and v2#574

Open
akrem-chabchoub wants to merge 11 commits intomasterfrom
feed-metrics
Open

feat(feed): add duration metrics for feed updates, retrieval, and availability in v1 and v2#574
akrem-chabchoub wants to merge 11 commits intomasterfrom
feed-metrics

Conversation

@akrem-chabchoub
Copy link
Contributor

@akrem-chabchoub akrem-chabchoub commented Mar 10, 2026

Feed check metrics

Adds Prometheus metrics to the feed checks (feed-v1 and feed) so their runs are observable like the other beekeeper checks.

Metrics

  • feed_update_duration_seconds – time for each feed update (upload + UpdateFeedWithReference / UpdateFeedWithRootChunk)
  • feed_retrieval_duration_seconds – time from FindFeedUpdate to DownloadFileBytes completion

Changes

  • New pkg/check/feed/metrics.go with two histograms
  • CheckV1 and CheckV2 implement metrics.Reporter and register collectors with the check runner
  • Subsystems: check_feed_v1 for feed-v1, check_feed_v2 for feed

@akrem-chabchoub akrem-chabchoub added this to the 2026 milestone Mar 10, 2026
@akrem-chabchoub akrem-chabchoub self-assigned this Mar 10, 2026
@akrem-chabchoub akrem-chabchoub marked this pull request as ready for review March 10, 2026 23:29
@gacevicljubisa
Copy link
Member

Most of the checks in the codebase are tracking successes and failures, so maybe add counter metrics:

  • FeedUpdatesTotal
  • FeedUpdateErrorsTotal
  • FeedRetrievalsTotal
  • FeedRetrievalErrorsTotal

@akrem-chabchoub
Copy link
Contributor Author

Most of the checks in the codebase are tracking successes and failures, so maybe add counter metrics:

  • FeedUpdatesTotal
  • FeedUpdateErrorsTotal
  • FeedRetrievalsTotal
  • FeedRetrievalErrorsTotal

Yes I agree, but for the purpose of this PR is to have performance metrics.
I can do it in another separate PR on top of this one, wdyt ?

@gacevicljubisa
Copy link
Member

Also,

Most of the checks in the codebase are tracking successes and failures, so maybe add counter metrics:

  • FeedUpdatesTotal
  • FeedUpdateErrorsTotal
  • FeedRetrievalsTotal
  • FeedRetrievalErrorsTotal

Yes I agree, but for the purpose of this PR is to have performance metrics. I can do it in another separate PR on top of this one, wdyt ?

If there is an issue for this please attach it and create separate PR then. If there is not, do how you prefer.

@gacevicljubisa
Copy link
Member

@akrem-chabchoub do we need to measure the checkAvailability flow, when RootRef is defined? I see that this is not covered.

@akrem-chabchoub akrem-chabchoub changed the title feat(metrics): add metrics tracking for feed updates and retrievals i… feat(feed): add duration metrics for feed updates, retrieval, and availability in v1 and v2 Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants