[experimental] - Support React Portal with Fabric#55463
Open
intergalacticspacehighway wants to merge 13 commits intofacebook:mainfrom
Open
[experimental] - Support React Portal with Fabric#55463intergalacticspacehighway wants to merge 13 commits intofacebook:mainfrom
intergalacticspacehighway wants to merge 13 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
intergalacticspacehighway
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This solution is built upon previous findings and some help from Claude. In previous findings it was noted that portal commits were getting overridden by the final root commit (and it only supported attaching portal to root node) but I thought the issue might be in the JS renderer.
In this solution, we store the portal children on cpp via
mountPortalChildrencall inreplaceContainerChildrenand they finally get committed in thecompleteSurfacecall. Maybe a solution at the JS renderer might be possible here but not sure since the shadow tree gets constructed on the commit phase (so it makes sense to attach portal children in that phase?). This also needs more understanding on how the portals were considered for persistence mode (used by RN Fabric) vs mutation mode (used by react dom). The fabric renderer change needs to be reviewed as i mostly took Claude's help there 😅. It will need to be upstream to the react repo if we consider merging this PR.Changelog:
[GENERAL] [ADDED] - React Portal support
Test Plan:
Portal-itest.jsPortalExample.jsScreen.Recording.2026-02-08.at.5.34.41.AM.mov