This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Changes needed to work with Visual Studio 2015#105
Open
makiolo wants to merge 2 commits intofacebookarchive:masterfrom
makiolo:master
Open
Changes needed to work with Visual Studio 2015#105makiolo wants to merge 2 commits intofacebookarchive:masterfrom makiolo:master
makiolo wants to merge 2 commits intofacebookarchive:masterfrom
makiolo:master
Conversation
ambiguation with abs function
compatibility with Visual Studio 2015
davidcernat
added a commit
to TES3MP/CrabNet
that referenced
this pull request
Jan 11, 2017
Changes are identicall to facebookarchive#105
| IF(NOT ${CMAKE_GENERATOR} STREQUAL "MSYS Makefiles") | ||
|
|
||
| IF( MSVC10 OR MSVC11 OR MSVC12 ) | ||
| IF( MSVC10 OR MSVC11 OR MSVC12 OR MSVC14 ) |
There was a problem hiding this comment.
Seems like a duplicate of this PR: #64
which I commented. The proper way to do it here, would probably be:
if (MSVC_VERSION GREATER_EQUAL 1600)
| #include "MTUSize.h" | ||
| #include <stdio.h> | ||
| #include <math.h> | ||
| #include <cmath> |
There was a problem hiding this comment.
As I commented also on #64,
personally I would rather just change the abs to an fabs and avoid header changes like this.
|
FYI: As pointed out by @davidstlyoui , the changes are actually a duplicate of #64 which was already incorporated in SLikeNet 0.1.0 and therefore is available in our fork as well: https://github.com/SLikeSoft/SLikeNet . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor changes, but needed.
Thanks.