Skip to content

Comments

When reusing PR, update the title and body#64

Open
jinfwhuang wants to merge 1 commit intofasterci:mainfrom
jinfwhuang:jin/2025-12-08-update-pr-title-body
Open

When reusing PR, update the title and body#64
jinfwhuang wants to merge 1 commit intofasterci:mainfrom
jinfwhuang:jin/2025-12-08-update-pr-title-body

Conversation

@jinfwhuang
Copy link
Contributor

When we are using a PR, we should be able to update the PR title and body. This is especially helpful when we want to include the commit information as part of the PR.

}

// Update the first matching PR
existingPR := prs[0]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in updateExistingPR always updates the first PR returned (prs[0]). If multiple open PRs match the criteria, this may result in updating the wrong PR. Consider iterating through all matching PRs or adding additional checks to ensure the correct PR is updated.

@michaelschiff
Copy link
Collaborator

hey @jinfwhuang sorry for the delay. mind elaborating a bit on the intent of this PR? the way im thinking about it (in the course of normal operations): a commit on main produces rendered outputs associated with the release train, a commit with the rendered output is pushed to the release branch (the message of this commit acts as a back-pointer to the commit which yielded the changes, and the deploy PR description is updated with the link to the PR for this same commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants