Skip to content

Kill child process on SIGTERM#89

Open
mkscrg wants to merge 1 commit intoflow:mainfrom
mkscrg:master
Open

Kill child process on SIGTERM#89
mkscrg wants to merge 1 commit intoflow:mainfrom
mkscrg:master

Conversation

@mkscrg
Copy link
Copy Markdown

@mkscrg mkscrg commented Oct 21, 2017

This is a fix for #88.

Ad-hoc test:

$ node_modules/.bin/flow server src 2>/dev/null &
[1] 10541
$ kill -s SIGTERM 10541
$ ps ax | grep flow
10594 s002  S+     0:00.00 grep flow

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mkscrg
Copy link
Copy Markdown
Author

mkscrg commented Oct 21, 2017

CLA signed.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mkscrg
Copy link
Copy Markdown
Author

mkscrg commented Oct 25, 2017

Looks like the AppVeyor build is broken on all commits. Works on my machine! 😝

@mkscrg
Copy link
Copy Markdown
Author

mkscrg commented Nov 1, 2017

cc @gabelevi maybe? Thoughts?

@sartaj
Copy link
Copy Markdown

sartaj commented May 17, 2018

The AppVeyor failure doesn't seem to be related to this PR

make test
'make' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants