fix(transport): filter whitespace-only AI text responses#759
Open
gspencergoog wants to merge 1 commit intoflutter:mainfrom
Open
fix(transport): filter whitespace-only AI text responses#759gspencergoog wants to merge 1 commit intoflutter:mainfrom
gspencergoog wants to merge 1 commit intoflutter:mainfrom
Conversation
Modify `A2uiTransportAdapter` and `A2uiAgentConnector` to trim incoming text parts from the AI model and discard any that are empty or consist only of whitespace. This prevents the UI from rendering empty messages or trailing newlines when the model responds with whitespace chunks.
Contributor
There was a problem hiding this comment.
Code Review
The changes effectively address the issue of whitespace-only AI text responses by trimming and filtering them out in both A2uiTransportAdapter and A2uiAgentConnector. This prevents the UI from rendering undesirable empty messages or trailing newlines, improving the overall user experience and data cleanliness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify
A2uiTransportAdapterandA2uiAgentConnectorto trim incoming text parts from the AI model and discard any that are empty or consist only of whitespace. This prevents the UI from rendering empty messages or trailing newlines when the model responds with whitespace chunks.Fixes #736