Draft
Conversation
zootalures
force-pushed
the
oc/squashRuntimeLayers
branch
from
23c2b50 to
82a9c8d
Compare
Contributor
|
Two issues @owencliffe. The native images don't pass on the build script args to the docker build command so passing "--squash" won't have any effect. The build-native script expects the first arg to be the runtime dir. You've made the first arg "--squash" which will result in failure. I've got a PR to update the native image builds pending: #246 |
zootalures
force-pushed
the
oc/squashRuntimeLayers
branch
2 times, most recently
from
d21e446 to
9f3ad42
Compare
zootalures
force-pushed
the
oc/squashRuntimeLayers
branch
from
9f3ad42 to
aeb99b0
Compare
astromechza
approved these changes
Feb 12, 2021
Contributor
astromechza
left a comment
astromechza
left a comment
There was a problem hiding this comment.
LGTM. although not sure how to build these locally to verify. the ./build.sh script gets stuck on a test somewhere
zootalures
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick POC to demonstrate doing docker-daemon level image squashing
This will change the behaviour of image pulls so should be reviewed w.r.t. actual system performance before merging.