Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Feb 2, 2026

Summary

Adds an is_self_hosted boolean tag to Sentry telemetry to distinguish between SaaS and self-hosted instances.

Changes

  • Add is_self_hosted tag in initSentry() based on SENTRY_URL configuration
  • Consolidate URL utilities in sentry-urls.ts:
    • Move isSentrySaasUrl from region.ts to sentry-urls.ts
    • Use DEFAULT_SENTRY_HOST from constants.ts (removes duplicate)
  • Remove getDefaultBaseUrl and isSentrySaasUrl from region.ts

Behavior

SENTRY_URL is_self_hosted
(default: https://sentry.io) false
https://us.sentry.io false
https://sentry.mycompany.com true

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (feedback) Add command to submit CLI feedback by betegon in #150
  • (telemetry) Add is_self_hosted tag by BYK in #153
  • (upgrade) Add self-update command by betegon in #132
  • Add update available notification by BYK in #151

Bug Fixes 🐛

  • (telemetry) Capture command errors to Sentry by betegon in #145
  • Update docs URL in help output by betegon in #149

Documentation 📚

  • (upgrade) Add documentation for upgrade command by betegon in #152
  • Update README and AGENTS.md by betegon in #148

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 2027 uncovered lines.
✅ Project coverage is 68.3%. Comparing base (base) to head (head).

Files with missing lines (27)
File Patch % Lines
human.ts 31.87% ⚠️ 682 Missing
resolve-target.ts 20.82% ⚠️ 251 Missing
oauth.ts 25.10% ⚠️ 194 Missing
upgrade.ts 34.25% ⚠️ 167 Missing
api-client.ts 71.60% ⚠️ 146 Missing
resolver.ts 3.23% ⚠️ 120 Missing
errors.ts 5.94% ⚠️ 95 Missing
migration.ts 47.44% ⚠️ 82 Missing
upgrade.ts 38.78% ⚠️ 60 Missing
api.ts 89.80% ⚠️ 47 Missing
seer.ts 75.54% ⚠️ 45 Missing
seer.ts 79.87% ⚠️ 30 Missing
preload.ts 39.02% ⚠️ 25 Missing
version-check.ts 76.00% ⚠️ 18 Missing
detector.ts 87.79% ⚠️ 16 Missing
schema.ts 64.10% ⚠️ 14 Missing
auth.ts 94.78% ⚠️ 7 Missing
utils.ts 97.59% ⚠️ 4 Missing
index.ts 95.06% ⚠️ 4 Missing
colors.ts 91.84% ⚠️ 4 Missing
telemetry.ts 97.20% ⚠️ 4 Missing
env-file.ts 97.17% ⚠️ 3 Missing
sentry-urls.ts 88.00% ⚠️ 3 Missing
alias.ts 98.56% ⚠️ 2 Missing
project-aliases.ts 97.40% ⚠️ 2 Missing
java.ts 97.22% ⚠️ 1 Missing
parser.ts 98.63% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    68.30%    68.30%        —%
==========================================
  Files           55        55         —
  Lines         6395      6395         —
  Branches         0         0         —
==========================================
+ Hits          4368      4368         —
- Misses        2027      2027         —
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK force-pushed the feat/telemetry-self-hosted-tag branch from 4a45717 to 13b0169 Compare February 2, 2026 13:28
Add a boolean tag to Sentry telemetry to distinguish between SaaS
and self-hosted Sentry instances.

Also consolidates URL utilities:
- Move isSentrySaasUrl to sentry-urls.ts (canonical location)
- Remove duplicate DEFAULT_SENTRY_URL from sentry-urls.ts (use constants.ts)
- Remove getDefaultBaseUrl and isSentrySaasUrl from region.ts (use sentry-urls.ts)
@BYK BYK force-pushed the feat/telemetry-self-hosted-tag branch from 13b0169 to 03ae0cf Compare February 2, 2026 13:36
@BYK BYK marked this pull request as ready for review February 2, 2026 13:39
@BYK BYK merged commit 383549f into main Feb 2, 2026
24 checks passed
@BYK BYK deleted the feat/telemetry-self-hosted-tag branch February 2, 2026 14:05
@BYK
Copy link
Member Author

BYK commented Feb 2, 2026

@sentry review

@BYK
Copy link
Member Author

BYK commented Feb 2, 2026

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants