Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

Resolves #4802:

Basically done here:

<!-- Dependencies for AndroidMavenLibrary references
Matching what was shipped in the 10.0.100 workloads to avoid NU1608 warnings
-->
<ItemGroup Condition="$(TargetFramework.StartsWith('net10'))">
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.9.2.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Common.Java8" Version="2.9.2.1" />
<!-- MAUI 10 references this version indirectly via Xamarin.AndroidX.SwipeRefreshLayout -->
<PackageReference Include="Xamarin.AndroidX.Core" Version="1.17.0" />
<!-- We have a dependency on 1.9.24 from here:
https://github.com/getsentry/sentry-java/blob/604a2616bebd80ea051cdcec916aa052b509c5a8/buildSrc/src/main/java/Config.kt#L6-L7
... but there's no NuGet package for that version. This version has been selected to
match the version that was available when net10.0 was released -->
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="2.2.21" />
</ItemGroup>

Note

I tried bumping Xamarin.AndroidX.Lifecycle.Common.Java8 and Xamarin.AndroidX.Lifecycle.Process to 2.10.0 but that gives us dependency conflicts in our Sentry.Maui package. It might be possible with a bit of sleuthing to work out where those come from (would have to be from the <UseMaui>true</UseMaui> include... so somewhere in the MS target files) but I think the fact that it breaks our builds is evidence enough that it's not the right version to reference so I left it at 2.9.2.1.


<ItemGroup>
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.3.2"/>
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0"/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps to the latest version of CommunityToolkit.Mvvm... typically we target the oldest version possible but CommunityToolkit.Mvvm has shared Java dependencies with Maui and also with some of the transitive dependencies we take through the Sentry SDK for Java. So for this particular integration, our approach has been to keep it as up to date as possible (as long as that isn't incompatible with either the versions of net-android we target or the dependencies we get via the Sentry SDK for Java).

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.86%. Comparing base (dd7e96d) to head (cb41e0c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4876      +/-   ##
==========================================
+ Coverage   73.85%   73.86%   +0.01%     
==========================================
  Files         483      483              
  Lines       17577    17577              
  Branches     3464     3464              
==========================================
+ Hits        12982    12984       +2     
+ Misses       3741     3740       -1     
+ Partials      854      853       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify we have the most appropriate transient dependencies for .net SDK 10.0.100

2 participants