Skip to content

feat(core): Add StreamedSpanEnvelope creation function#19153

Merged
Lms24 merged 5 commits intolms/feat-span-firstfrom
lms/feat-core-envelope-creation
Feb 4, 2026
Merged

feat(core): Add StreamedSpanEnvelope creation function#19153
Lms24 merged 5 commits intolms/feat-span-firstfrom
lms/feat-core-envelope-creation

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 4, 2026

Adds a utility to create a span v2 envelope from a SerializedSpan array + tests.

Note: I think here, the "v2" naming makes more sense than the StreamSpan patter we use for user-facing functionality. This function should never be called by users, and the envelope is type span with content type span.v2+json

ref #17836

@Lms24 Lms24 marked this pull request as ready for review February 4, 2026 10:05
@Lms24 Lms24 self-assigned this Feb 4, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@Lms24 Lms24 mentioned this pull request Feb 4, 2026
22 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Codecov Results 📊


Generated by Codecov Action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.43 kB added added
@sentry/browser - with treeshaking flags 23.89 kB added added
@sentry/browser (incl. Tracing) 42.25 kB added added
@sentry/browser (incl. Tracing, Profiling) 46.88 kB added added
@sentry/browser (incl. Tracing, Replay) 80.88 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.48 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 85.58 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 97.76 kB added added
@sentry/browser (incl. Feedback) 42.15 kB added added
@sentry/browser (incl. sendFeedback) 30.11 kB added added
@sentry/browser (incl. FeedbackAsync) 35.12 kB added added
@sentry/browser (incl. Metrics) 26.55 kB added added
@sentry/browser (incl. Logs) 26.7 kB added added
@sentry/browser (incl. Metrics & Logs) 27.36 kB added added
@sentry/react 27.16 kB added added
@sentry/react (incl. Tracing) 44.48 kB added added
@sentry/vue 29.88 kB added added
@sentry/vue (incl. Tracing) 44.05 kB added added
@sentry/svelte 25.45 kB added added
CDN Bundle 27.96 kB added added
CDN Bundle (incl. Tracing) 43.02 kB added added
CDN Bundle (incl. Logs, Metrics) 28.8 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 43.85 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 67.75 kB added added
CDN Bundle (incl. Tracing, Replay) 79.76 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 80.62 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 85.2 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.11 kB added added
CDN Bundle - uncompressed 81.78 kB added added
CDN Bundle (incl. Tracing) - uncompressed 127.35 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 84.61 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 130.18 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 207.99 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 243.95 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 246.77 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.75 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 259.56 kB added added
@sentry/nextjs (client) 46.85 kB added added
@sentry/sveltekit (client) 42.63 kB added added
@sentry/node-core 52.17 kB added added
@sentry/node 166.22 kB added added
@sentry/node - without tracing 93.95 kB added added
@sentry/aws-serverless 109.46 kB added added

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,795 - - added
GET With Sentry 1,681 19% - added
GET With Sentry (error only) 6,159 70% - added
POST Baseline 1,167 - - added
POST With Sentry 596 51% - added
POST With Sentry (error only) 1,060 91% - added
MYSQL Baseline 3,230 - - added
MYSQL With Sentry 417 13% - added
MYSQL With Sentry (error only) 2,672 83% - added

/**
* Creates a span v2 span streaming envelope
*/
export function createSpanV2Envelope(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Just that we don't forget: #19140 (comment)

@Lms24 Lms24 changed the title feat(core): Add Spanv2 envelope creation function feat(core): Add StreamedSpanEnvelope creation function Feb 4, 2026
@Lms24 Lms24 merged commit a3e74d9 into lms/feat-span-first Feb 4, 2026
214 checks passed
@Lms24 Lms24 deleted the lms/feat-core-envelope-creation branch February 4, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants