feat(seer): Only remind people to setup Seer if the org has GitHub integration #107288
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration For other integrations, like BitBucket and GitLab, we dont want to send a reminder because these things should be as setup as possible already. The extra steps are github only right now (but coming soon to more SCMs!)
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The SCM_PROVIDER_KEYS constant was missing 'github_enterprise', causing GitHub Enterprise integrations to be filtered out when determining if an organization has GitHub integration. This resulted in the Seer config reminder being incorrectly hidden for organizations using GitHub Enterprise with other SCMs like GitLab or Bitbucket.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For other integrations, like BitBucket and GitLab, we dont want to send a reminder because these things should be as setup as possible already. The extra steps are github only right now (but coming soon to more SCMs!)
Followup of: #106931
Fixes CW-720