fix(preprod): Remove ineffective retry logic for size status checks #107303
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retry configuration only retried on `ApiRateLimitedError` with 60-second delays, but GitHub rate limits use fixed hourly windows. Retrying at 60s intervals cannot succeed because the rate limit won't reset until the `x-ratelimit-reset` timestamp (up to 1 hour later). Removing this retry logic eliminates wasted compute cycles on retries that have no chance of success.
github-actions
bot
added
the
Scope: Backend
NicoHinderling
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
create_preprod_status_check_taskthat only retried onApiRateLimitedErrorwith 60-second delaysx-ratelimit-resettimestamp, up to 1 hour later)Test plan
tests/sentry/preprod/vcs/status_checks/size/test_status_checks_tasks.py)