Replacing checks for '/' in branch names by checks for "origin/"#105
Closed
johanneslerch wants to merge 1 commit intogit-school:gh-pagesfrom
Closed
Replacing checks for '/' in branch names by checks for "origin/"#105johanneslerch wants to merge 1 commit intogit-school:gh-pagesfrom
johanneslerch wants to merge 1 commit intogit-school:gh-pagesfrom
Conversation
Author
|
Re-created this pull request using a separate branch to avoid mixing several features into a single pull request. Please, consider #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem described in #101 seems to be caused by several locations checking if a branch name contains a forward slash '/' to identify remote branches. However, this over-approximating check makes it impossible to illustrate, e.g., a git flow using branch names like "feature/foobar".
In my changes I replaced the check for '/' by a check for "origin/", which seems to solve the problem. However, this solution will again fail as soon as a remote is not called origin, so this is also not the best solution.
It can be tested already on the fork: https://johanneslerch.github.io/visualizing-git/