Merged
Conversation
Breaking changes addressed: - Update storybook packages to v9.1.6 - Remove packages now consolidated into core storybook: - @storybook/addon-actions (now storybook/actions) - @storybook/addon-essentials (built-in) - @storybook/addon-interactions (built-in) - @storybook/blocks (now @storybook/addon-docs/blocks) - @storybook/components (now storybook/internal/components) - @storybook/manager-api (now storybook/manager-api) - @storybook/theming (now storybook/theming) - Add @storybook/addon-docs for MDX support - Update import paths to new package structure - Convert preset.ts from CommonJS to ESM - Update Overview.mdx to use @storybook/addon-docs/blocks
ginsbach
force-pushed
the
ginsbach/upgrade-storybook-9
branch
from
6a9283c to
9e18768
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the ql-vscode extension’s Storybook setup from v8 to v9, updating dependencies, configuration, and custom addons to align with the new package structure and ESM-based APIs.
Changes:
- Bump Storybook core and related packages in
package.json/package-lock.jsonto the 9.1.x series and remove legacy addon packages now folded into core. - Update Storybook configuration and stories (
.storybookconfigs and*.stories.tsx/Overview.mdx) to use the newstorybook/*and@storybook/addon-docs/blocksimport paths. - Convert the custom VS Code theme preset from CommonJS to ESM and wire it into the updated Storybook builder and addon configuration.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
extensions/ql-vscode/src/stories/results/AlertTable.stories.tsx |
Switches action handling import from @storybook/addon-actions to the new storybook/actions entrypoint. |
extensions/ql-vscode/src/stories/Overview.mdx |
Updates MDX docs to import Meta from @storybook/addon-docs/blocks instead of the deprecated @storybook/blocks. |
extensions/ql-vscode/package.json |
Upgrades Storybook-related devDependencies (React, Vite builder, addons, CLI) to 9.1.x and adds @storybook/addon-docs. |
extensions/ql-vscode/package-lock.json |
Locks updated Storybook ecosystem versions and transitive dependencies to match the new 9.1.x setup. |
extensions/ql-vscode/.storybook/vscode-theme-addon/preset.ts |
Converts the preset to ESM and switches from require.resolve to URL-based path construction for preview and manager entries. |
extensions/ql-vscode/.storybook/vscode-theme-addon/manager.tsx |
Updates addon registration to use the new storybook/manager-api import. |
extensions/ql-vscode/.storybook/vscode-theme-addon/ThemeSelector.tsx |
Updates manager-side hooks and components to use storybook/manager-api and storybook/internal/components. |
extensions/ql-vscode/.storybook/preview.ts |
Switches theming and action imports to storybook/theming and storybook/actions to match v9 entrypoints. |
extensions/ql-vscode/.storybook/manager.ts |
Updates manager configuration imports to use new storybook/manager-api and storybook/theming paths. |
extensions/ql-vscode/.storybook/main.ts |
Adjusts Storybook configuration to include @storybook/addon-docs and remove now-built-in addons, simplifying the addons list. |
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes addressed: