Skip to content

chore: improve tests without assertions#1201

Merged
czosel merged 3 commits intomainfrom
chore/assertion-test
Mar 16, 2026
Merged

chore: improve tests without assertions#1201
czosel merged 3 commits intomainfrom
chore/assertion-test

Conversation

@jorgsowa
Copy link
Collaborator

@jorgsowa jorgsowa commented Mar 16, 2026

Test suite warns that the test doesn't have any assertions, so let's add it.

  • test/snapshot/namespace.test.js - filled 3 empty todo tests. Two of them were redundant. There were not enough tests for the use statement.
  • test/snapshot/string.test.js - applied assertions to the test. The test only tested parsing, without checking the proper structure.
  • test/ast.test.js - added assertion

@jorgsowa jorgsowa marked this pull request as draft March 16, 2026 20:59
@jorgsowa jorgsowa force-pushed the chore/assertion-test branch from 731e2d8 to 66b8f61 Compare March 16, 2026 21:30
@jorgsowa jorgsowa changed the title chore: add assertion to the test debug mode chore: improve test without assertions Mar 16, 2026
@jorgsowa jorgsowa marked this pull request as ready for review March 16, 2026 22:00
@jorgsowa jorgsowa changed the title chore: improve test without assertions chore: improve tests without assertions Mar 16, 2026
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@czosel czosel merged commit ba6d1c4 into main Mar 16, 2026
6 checks passed
@alexander-akait alexander-akait deleted the chore/assertion-test branch March 17, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants