Open
Conversation
GCC 15 has been released (fairly) recently, and with it come C23
features such as built-in `bool` types, which obviate the need for
defining these in each code-base.
In our case, this also causes compilation errors with GCC 15 (unless the
`-std=gnu17` flag is passed), e.g.:
./test.go:16:17: error: two or more data types in declaration specifiers
16 | typedef uint8_t bool;
| ^~~~
This commit wraps these `typedef` declarations in `__STDC_VERSION__`
checks, skipping if the version is C23 or over.
deuill
force-pushed
the
c23-fix-compilation
branch
from
8be0b88 to
0e657f8
Compare
Contributor
Author
|
Tests will fail until #378 is merged (and this rebased). |
b-long
added a commit
to b-long/gopy
that referenced
this pull request
Jan 25, 2026
Wraps 'typedef uint8_t bool;' with preprocessor guards to avoid conflicts with C23's native bool type. This fixes compilation errors with newer C compilers that default to C23 standard. Based on go-python#379 by @deuill. Co-Authored-By: Marid de Uill <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 has been released (fairly) recently, and with it come C23 features such as built-in
booltypes, which obviate the need for defining these in each code-base.In our case, this also causes compilation errors with GCC 15 (unless the
-std=gnu17flag is passed), e.g.:This commit wraps these
typedefdeclarations in__STDC_VERSION__checks, skipping if the version is C23 or over.